diff options
| author | Jack Koenig | 2021-01-21 20:31:39 -0800 |
|---|---|---|
| committer | GitHub | 2021-01-21 20:31:39 -0800 |
| commit | 53c24cb0a369d4c4f57c28c098b30e4d3640eac2 (patch) | |
| tree | 825776855e7d2fc28ef32ebb05df7339c24e00b3 /core | |
| parent | 7e4d1eeb03fddff735e67e3fe36b6efbfac39711 (diff) | |
Apply suggestions from code review
Co-authored-by: Megan Wachs <megan@sifive.com>
Diffstat (limited to 'core')
| -rw-r--r-- | core/src/main/scala/chisel3/BlackBox.scala | 4 | ||||
| -rw-r--r-- | core/src/main/scala/chisel3/RawModule.scala | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/core/src/main/scala/chisel3/BlackBox.scala b/core/src/main/scala/chisel3/BlackBox.scala index 2aa9a243..03543790 100644 --- a/core/src/main/scala/chisel3/BlackBox.scala +++ b/core/src/main/scala/chisel3/BlackBox.scala @@ -146,10 +146,10 @@ abstract class BlackBox(val params: Map[String, Param] = Map.empty[String, Param private[chisel3] override def generateComponent(): Component = { _compatAutoWrapPorts() // pre-IO(...) compatibility hack - // Restrict IO to just io, clock, and reset + // Restrict IO to just io, clock, and reset require(_io != null, "BlackBox must have a port named 'io' of type Record!") require(portsContains(_io), "BlackBox must have io wrapped in IO(...)") - require(portsSize == 1, "BlackBox must only have io as IO") + require(portsSize == 1, "BlackBox must only have one IO, called `io`") require(!_closed, "Can't generate module more than once") _closed = true diff --git a/core/src/main/scala/chisel3/RawModule.scala b/core/src/main/scala/chisel3/RawModule.scala index a686fd7e..0adacedb 100644 --- a/core/src/main/scala/chisel3/RawModule.scala +++ b/core/src/main/scala/chisel3/RawModule.scala @@ -202,7 +202,7 @@ package object internal { */ abstract class LegacyModule(implicit moduleCompileOptions: CompileOptions) extends Module { // Provide a non-deprecated constructor - def this(override_clock: Option[Clock]=None, override_reset: Option[Bool]=None) + def this(override_clock: Option[Clock] = None, override_reset: Option[Bool]=None) (implicit moduleCompileOptions: CompileOptions) = { this() this.override_clock = override_clock @@ -243,7 +243,7 @@ package object internal { /** Legacy BlackBox class will reflectively autowrap val io * - * '''Do not use this class in user code'''. Use whichever `Module` is imported by your wildcard + * '''Do not use this class in user code'''. Use whichever `BlackBox` is imported by your wildcard * import (preferably `import chisel3._`). */ abstract class LegacyBlackBox(params: Map[String, Param] = Map.empty[String, Param]) |