diff options
| author | Schuyler Eldridge | 2020-07-10 22:55:47 -0400 |
|---|---|---|
| committer | Schuyler Eldridge | 2020-07-16 12:51:54 -0400 |
| commit | debee42971229c7d1f1f698d65ea3fd089609af5 (patch) | |
| tree | 379a7b85741ac56c08bd98e94b7051ac7f4b774f /jqf/src/main | |
| parent | f5dd8ddc72ce829406337f22e73cac27b58aa521 (diff) | |
Simplify CustomTransformSpec
Refactor the test used in the CustomTransformSpec to assert that
inputForm=LowForm legacy transforms run right before the emitter (see
note below!). The new test looks only for a list of (customTransform,
emitter) in a sliding, size-2 window of the flattened transform order.
Previously, this was looking for a match before and after the custom
transform. The old implementation necessitate busywork updates of the
test when new transforms are added that changed the transform running
before the custom transform.
Note: this test, as written is intentionally wrong. When verification
statements were added, the test was changed to not do what it's
supposed to do. Namely, the test is supposed to ensure that an
inputForm=LowForm transform runs immediately before its emitter.
However, the test is actually checking that the custom transform runs
before transforms that convert and remove verification statements. I'm
intentionally leaving the test broken, but doing the refactor in order
to make this easier to manually backport to the 1.3.x branch.
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
Diffstat (limited to 'jqf/src/main')
0 files changed, 0 insertions, 0 deletions
