diff options
| author | Adam Izraelevitz | 2020-02-11 16:41:58 -0800 |
|---|---|---|
| committer | GitHub | 2020-02-12 00:41:58 +0000 |
| commit | 1937cfd58c070774e53e5bffc22bac779f338cdd (patch) | |
| tree | e87bd18b273da8344d89664d3a1aa39da3fa270f /.github/PULL_REQUEST_TEMPLATE.md | |
| parent | 4531a8ff2edf4cb7b06ba46ff6fc82ca2a7a1ec1 (diff) | |
Add reviewer checklist / update contributor checklist (#1375)
* Add reviewer checklist / update contributor checklist
* Update PULL_REQUEST_TEMPLATE.md
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Diffstat (limited to '.github/PULL_REQUEST_TEMPLATE.md')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 9c462b3e..0edc672b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,8 @@ -### Checklist +### Contributor Checklist +- [ ] Did you add Scaladoc to every public function/method? +- [ ] Did you add at least one test demonstrating the PR? +- [ ] Did you delete any extraneous printlns/debugging code? - [ ] Did you specify the type of improvement? - [ ] Did you state the API impact? - [ ] Did you specify the code generation impact? @@ -31,3 +34,9 @@ <!-- Options are: --> <!-- - Squash: The PR will be squashed and merged (choose this if you have no preference. --> <!-- - Rebase: You will rebase the PR onto master and it will be merged with a merge commit. --> + +### Reviewer Checklist (only modified by reviewer) +- [ ] Did you add the appropriate labels? +- [ ] Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ? +- [ ] Did you review? +- [ ] Did you mark as `Please Merge`? |