refactor: Simplify proof-upgrade-elpa-packages

* Lastly, package-menu-async keeps its initial value even if we C-g.

1 files changed, 2 insertions, 5 deletions

diff --git a/generic/proof-utils.el b/generic/proof-utils.el
index 07bbaf04..673b269c 100644
--- a/generic/proof-utils.el
+++ b/generic/proof-utils.el
@@ -112,17 +112,14 @@ Return nil if not a script buffer or if no active scripting buffer."
   (interactive)
   (unless (proof-try-require 'package)
     (error "The package feature is not available!"))
-  (let ((old-async package-menu-async))
-    (setq package-menu-async nil)
+  (let ((package-menu-async nil))
     (package-list-packages)
     (package-menu-mark-upgrades)
     (let ((use-dialog-box nil))
       ;; make `y-or-n-p' show up within the minibuffer
       ;; even if `proof-upgrade-elpa-packages' is called interactively
       ;; to avoid any dialog-box overflow if many packages are updated
-      (package-menu-execute))
-    (setq package-menu-async old-async)))
-
+      (package-menu-execute))))
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;;