aboutsummaryrefslogtreecommitdiff
path: root/ports/stm32/eth.c
diff options
context:
space:
mode:
authorDamien George2019-06-03 17:06:35 +1000
committerDamien George2019-06-03 17:14:34 +1000
commitce8262a164d33d222de55677523593806404176e (patch)
treeb73da06b8f8dff53dbdf7768990982e879ea1f4f /ports/stm32/eth.c
parent62fe47aa3a96056e03e4dffdf50a924f0cac1f06 (diff)
stm32/modnetwork: Replace generic netif NIC polling with specific code.
It doesn't work to tie the polling of an underlying NIC driver (eg to check the NIC for pending Ethernet frames) with its associated lwIP netif. This is because most NICs are implemented with IRQs and don't need polling, because there can be multiple lwIP netif's per NIC driver, and because it restricts the use of the netif->state variable. Instead the NIC should have its own specific way of processing incoming Ethernet frame. This patch removes this generic NIC polling feature, and for the only driver that uses it (Wiznet5k) replaces it with an explicit call to the poll function (which could eventually be improved by using a proper external interrupt).
Diffstat (limited to 'ports/stm32/eth.c')
-rw-r--r--ports/stm32/eth.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/ports/stm32/eth.c b/ports/stm32/eth.c
index 665495c17..6a1ef99af 100644
--- a/ports/stm32/eth.c
+++ b/ports/stm32/eth.c
@@ -107,7 +107,6 @@ typedef struct _eth_dma_t {
} eth_dma_t;
typedef struct _eth_t {
- mod_network_nic_type_t base;
uint32_t trace_flags;
struct netif netif;
struct dhcp dhcp_struct;