aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAyke van Laethem2018-08-02 15:42:24 +0200
committerDamien George2019-01-31 17:26:26 +1100
commit4e1c2fc8318480dded4a4a031a9986d8db578030 (patch)
treee9253c47992eaceba84cd90c3e8cf29a3d1a88dc
parent1ba962ff574a6befb2e7233e5669eaf25f36a1bb (diff)
nrf: Shrink "<peripheral> does not exist" error messages.
Code size reductions: nrf51: -132 nrf52: -188
-rw-r--r--ports/nrf/modules/board/led.c2
-rw-r--r--ports/nrf/modules/machine/adc.c3
-rw-r--r--ports/nrf/modules/machine/i2c.c3
-rw-r--r--ports/nrf/modules/machine/pin.c2
-rw-r--r--ports/nrf/modules/machine/pwm.c6
-rw-r--r--ports/nrf/modules/machine/rtcounter.c3
-rw-r--r--ports/nrf/modules/machine/spi.c6
-rw-r--r--ports/nrf/modules/machine/timer.c9
-rw-r--r--ports/nrf/modules/machine/uart.c3
9 files changed, 13 insertions, 24 deletions
diff --git a/ports/nrf/modules/board/led.c b/ports/nrf/modules/board/led.c
index a576b7088..687348cb8 100644
--- a/ports/nrf/modules/board/led.c
+++ b/ports/nrf/modules/board/led.c
@@ -105,7 +105,7 @@ STATIC mp_obj_t led_obj_make_new(const mp_obj_type_t *type, size_t n_args, size_
// check led number
if (!(1 <= led_id && led_id <= NUM_LEDS)) {
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError, "LED(%d) does not exist", led_id));
+ mp_raise_ValueError("LED doesn't exist");
}
// return static led object
diff --git a/ports/nrf/modules/machine/adc.c b/ports/nrf/modules/machine/adc.c
index ce4805692..55b68c6b8 100644
--- a/ports/nrf/modules/machine/adc.c
+++ b/ports/nrf/modules/machine/adc.c
@@ -100,8 +100,7 @@ STATIC int adc_find(mp_obj_t id) {
&& machine_adc_obj[adc_idx].id != (uint8_t)-1) {
return adc_idx;
}
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError,
- "ADC(%d) does not exist", adc_id));
+ mp_raise_ValueError("ADC doesn't exist");
}
/// \method __str__()
diff --git a/ports/nrf/modules/machine/i2c.c b/ports/nrf/modules/machine/i2c.c
index 15f024f0e..8b79342a3 100644
--- a/ports/nrf/modules/machine/i2c.c
+++ b/ports/nrf/modules/machine/i2c.c
@@ -58,8 +58,7 @@ STATIC int i2c_find(mp_obj_t id) {
if (i2c_id >= 0 && i2c_id < MP_ARRAY_SIZE(machine_hard_i2c_obj)) {
return i2c_id;
}
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError,
- "I2C(%d) does not exist", i2c_id));
+ mp_raise_ValueError("I2C doesn't exist");
}
STATIC void machine_hard_i2c_print(const mp_print_t *print, mp_obj_t self_in, mp_print_kind_t kind) {
diff --git a/ports/nrf/modules/machine/pin.c b/ports/nrf/modules/machine/pin.c
index df4eb471e..d3458d0ae 100644
--- a/ports/nrf/modules/machine/pin.c
+++ b/ports/nrf/modules/machine/pin.c
@@ -207,7 +207,7 @@ const pin_obj_t *pin_find(mp_obj_t user_obj) {
return pin_obj;
}
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError, "pin '%s' not a valid pin identifier", mp_obj_str_get_str(user_obj)));
+ mp_raise_ValueError("not a valid pin identifier");
}
/// \method __str__()
diff --git a/ports/nrf/modules/machine/pwm.c b/ports/nrf/modules/machine/pwm.c
index ed4380656..8e5c2e23f 100644
--- a/ports/nrf/modules/machine/pwm.c
+++ b/ports/nrf/modules/machine/pwm.c
@@ -99,8 +99,7 @@ STATIC int hard_pwm_find(mp_obj_t id) {
if (pwm_id >= 0 && pwm_id < MP_ARRAY_SIZE(machine_hard_pwm_obj)) {
return pwm_id;
}
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError,
- "PWM(%d) does not exist", pwm_id));
+ mp_raise_ValueError("PWM doesn't exist");
}
return -1;
}
@@ -252,8 +251,7 @@ STATIC mp_obj_t machine_hard_pwm_make_new(mp_arg_val_t *args) {
if (args[ARG_period].u_obj != MP_OBJ_NULL) {
self->p_config->period = mp_obj_get_int(args[ARG_period].u_obj);
} else {
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError,
- "PWM period has to be within 16000 frequence cycles", self->p_config->period));
+ mp_raise_ValueError("PWM period must be within 16000 cycles");
}
if (args[ARG_duty].u_obj != MP_OBJ_NULL) {
diff --git a/ports/nrf/modules/machine/rtcounter.c b/ports/nrf/modules/machine/rtcounter.c
index ea4a17626..0afdf5bd2 100644
--- a/ports/nrf/modules/machine/rtcounter.c
+++ b/ports/nrf/modules/machine/rtcounter.c
@@ -116,8 +116,7 @@ STATIC int rtc_find(mp_obj_t id) {
if (rtc_id >= 0 && rtc_id < MP_ARRAY_SIZE(machine_rtc_obj)) {
return rtc_id;
}
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError,
- "RTCounter(%d) does not exist", rtc_id));
+ mp_raise_ValueError("RTCounter doesn't exist");
}
STATIC void rtc_print(const mp_print_t *print, mp_obj_t self_in, mp_print_kind_t kind) {
diff --git a/ports/nrf/modules/machine/spi.c b/ports/nrf/modules/machine/spi.c
index ce75b6caf..95331e241 100644
--- a/ports/nrf/modules/machine/spi.c
+++ b/ports/nrf/modules/machine/spi.c
@@ -140,16 +140,14 @@ STATIC int spi_find(mp_obj_t id) {
return 1;
#endif
}
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError,
- "SPI(%s) does not exist", port));
+ mp_raise_ValueError("SPI doesn't exist");
} else {
// given an integer id
int spi_id = mp_obj_get_int(id);
if (spi_id >= 0 && spi_id < MP_ARRAY_SIZE(machine_hard_spi_obj)) {
return spi_id;
}
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError,
- "SPI(%d) does not exist", spi_id));
+ mp_raise_ValueError("SPI doesn't exist");
}
}
diff --git a/ports/nrf/modules/machine/timer.c b/ports/nrf/modules/machine/timer.c
index 07f1f496e..e5e84a688 100644
--- a/ports/nrf/modules/machine/timer.c
+++ b/ports/nrf/modules/machine/timer.c
@@ -75,8 +75,7 @@ STATIC int timer_find(mp_obj_t id) {
if (timer_id >= 0 && timer_id < MP_ARRAY_SIZE(machine_timer_obj)) {
return timer_id;
}
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError,
- "Timer(%d) does not exist", timer_id));
+ mp_raise_ValueError("Timer doesn't exist");
}
STATIC void timer_print(const mp_print_t *print, mp_obj_t o, mp_print_kind_t kind) {
@@ -113,15 +112,13 @@ STATIC mp_obj_t machine_timer_make_new(const mp_obj_type_t *type, size_t n_args,
#if BLUETOOTH_SD
if (timer_id == 0) {
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError,
- "Timer(%d) reserved by Bluetooth LE stack.", timer_id));
+ mp_raise_ValueError("Timer reserved by Bluetooth LE stack");
}
#endif
#if MICROPY_PY_MACHINE_SOFT_PWM
if (timer_id == 1) {
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError,
- "Timer(%d) reserved by ticker driver.", timer_id));
+ mp_raise_ValueError("Timer reserved by ticker driver");
}
#endif
diff --git a/ports/nrf/modules/machine/uart.c b/ports/nrf/modules/machine/uart.c
index 2ddee79d1..cef98fb07 100644
--- a/ports/nrf/modules/machine/uart.c
+++ b/ports/nrf/modules/machine/uart.c
@@ -67,8 +67,7 @@ STATIC int uart_find(mp_obj_t id) {
if (uart_id >= 0 && uart_id < MP_ARRAY_SIZE(machine_hard_uart_obj)) {
return uart_id;
}
- nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError,
- "UART(%d) does not exist", uart_id));
+ mp_raise_ValueError("UART doesn't exist");
}
void uart_irq_handler(mp_uint_t uart_id) {