diff options
| author | glondu | 2010-09-30 18:45:31 +0000 |
|---|---|---|
| committer | glondu | 2010-09-30 18:45:31 +0000 |
| commit | 9a7da63b880cbeb3e58af5b2e0b39afcd650c253 (patch) | |
| tree | 11cd51860193fd59d7550b4804246bddea1e9d79 /parsing | |
| parent | 77e3ca28bbac9d973fbf0c5cd36de58159356710 (diff) | |
Simplify tactic(_)-bound arguments in TACTIC EXTEND rules
Arguments bound with tactic(_) in TACTIC EXTEND rules are now of type
glob_tactic_expr, instead of glob_tactic_expr * tactic. Only the first
component is kept, the second one can be obtained with
Tacinterp.eval_tactic.
Rationale: these declare parsing rules, and eval_tactic is a semantic
action, and therefore should be done in the rule body
instead. Moreover, having the glob_tactic_expr and its evaluation
captured by these rules was quite confusing IMHO.
git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/trunk@13480 85f007b7-540e-0410-9357-904b9bb8a0f7
Diffstat (limited to 'parsing')
| -rw-r--r-- | parsing/tacextend.ml4 | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/parsing/tacextend.ml4 b/parsing/tacextend.ml4 index 9cafb79f73..e1ae919663 100644 --- a/parsing/tacextend.ml4 +++ b/parsing/tacextend.ml4 @@ -42,12 +42,6 @@ let rec make_let e = function let loc = join_loc loc (MLast.loc_of_expr e) in let e = make_let e l in let v = <:expr< Genarg.out_gen $make_wit loc t$ $lid:p$ >> in - let v = - (* Special case for tactics which must be stored in algebraic - form to avoid marshalling closures and to be reprinted *) - if is_tactic_genarg t then - <:expr< ($v$, Tacinterp.eval_tactic $v$) >> - else v in <:expr< let $lid:p$ = $v$ in $e$ >> | _::l -> make_let e l @@ -85,9 +79,7 @@ let rec make_eval_tactic e = function let p = Names.string_of_id p in let loc = join_loc loc (MLast.loc_of_expr e) in let e = make_eval_tactic e l in - (* Special case for tactics which must be stored in algebraic - form to avoid marshalling closures and to be reprinted *) - <:expr< let $lid:p$ = ($lid:p$,Tacinterp.eval_tactic $lid:p$) in $e$ >> + <:expr< let $lid:p$ = $lid:p$ in $e$ >> | _::l -> make_eval_tactic e l let rec make_fun e = function |
