diff options
| author | Théo Zimmermann | 2020-04-07 10:42:29 +0200 |
|---|---|---|
| committer | Théo Zimmermann | 2020-04-20 15:52:01 +0200 |
| commit | 9de39626d925aa8ed0138fc5b90ee30ccf1ac4c1 (patch) | |
| tree | 904fcae80ca31bbe9ebc33478521747f7b9d6847 /library | |
| parent | 078e6c6d27bc3a13bb9e7ac6c9c5b8e05450af80 (diff) | |
Improve undeclared key messages.
Diffstat (limited to 'library')
| -rw-r--r-- | library/goptions.ml | 14 | ||||
| -rw-r--r-- | library/goptions.mli | 1 |
2 files changed, 11 insertions, 4 deletions
diff --git a/library/goptions.ml b/library/goptions.ml index 1418407533..fbacd07226 100644 --- a/library/goptions.ml +++ b/library/goptions.ml @@ -35,8 +35,13 @@ type option_state = { let nickname table = String.concat " " table +let error_no_table_of_this_type ~kind key = + user_err ~hdr:"Goptions" + (str ("There is no " ^ kind ^ "-valued table with this name: \"" ^ nickname key ^ "\".")) + let error_undeclared_key key = - user_err ~hdr:"Goptions" (str (nickname key) ++ str ": no table or option of this type") + user_err ~hdr:"Goptions" + (str ("There is no flag, option or table with this name: \"" ^ nickname key ^ "\".")) (****************************************************************************) (* 1- Tables *) @@ -387,9 +392,10 @@ let declare_interpreted_string_option_and_ref ~depr ~key ~(value:'a) from_string (* Setting values of options *) let warn_unknown_option = - CWarnings.create ~name:"unknown-option" ~category:"option" - (fun key -> strbrk "There is no option " ++ - str (nickname key) ++ str ".") + CWarnings.create + ~name:"unknown-option" ~category:"option" + (fun key -> strbrk "There is no flag or option with this name: \"" ++ + str (nickname key) ++ str "\".") let set_option_value ?(locality = OptDefault) check_and_cast key v = let opt = try Some (get_option key) with Not_found -> None in diff --git a/library/goptions.mli b/library/goptions.mli index 336cae420c..59b1667f5a 100644 --- a/library/goptions.mli +++ b/library/goptions.mli @@ -204,4 +204,5 @@ type option_state = { val get_tables : unit -> option_state OptionMap.t val print_tables : unit -> Pp.t +val error_no_table_of_this_type : kind:string -> option_name -> 'a val error_undeclared_key : option_name -> 'a |