diff options
| author | Pierre-Marie Pédrot | 2021-03-25 17:23:03 +0100 |
|---|---|---|
| committer | Pierre-Marie Pédrot | 2021-03-26 12:15:39 +0100 |
| commit | 35c1d9e7add9a415d1406e6bb1eae7bd67ba5357 (patch) | |
| tree | 05ab0584788f59f5e97ffd65049a4a2e7c8eef2e /kernel/vmlambda.ml | |
| parent | 71453f1643b55679d44caee30ce5541b5aa47263 (diff) | |
Never store persistent arrays as VM structured values.
Bytecode execution of persistent arrays can modify structured values meant
to be marshalled in vo files. Some VM values are not marshallable, leading
to this anomaly.
There are further issues with the use of a hash table to store structured
values, since they rely on structural equality and hashing functions.
Persistent arrays are not safe in this context.
Fixes #14006: Coqc cannot save .vo files containing primitive arrays.
Diffstat (limited to 'kernel/vmlambda.ml')
| -rw-r--r-- | kernel/vmlambda.ml | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/kernel/vmlambda.ml b/kernel/vmlambda.ml index e353348ac7..ee32384ec9 100644 --- a/kernel/vmlambda.ml +++ b/kernel/vmlambda.ml @@ -494,10 +494,6 @@ let makeblock tag nparams arity args = else Lmakeblock(tag, args) let makearray args def = - try - let p = Array.map get_value args in - Lval (val_of_parray @@ Parray.unsafe_of_array p (get_value def)) - with Not_found -> let ar = Lmakeblock(0, args) in (* build the ocaml array *) let kind = Lmakeblock(0, [|ar; def|]) in (* Parray.Array *) Lmakeblock(0,[|kind|]) (* the reference *) |