[location] Make location optional in Loc.located

This completes the Loc.ghost removal, the idea is to gear the API
towards optional, but uniform, location handling.

We don't print <unknown> anymore in the case there is no location.
This is what the test suite expects.

The old printing logic for located items was a bit inconsistent as
it sometimes printed <unknown> and other times it printed nothing as
the caller checked for `is_ghost` upstream.

1 files changed, 6 insertions, 6 deletions

diff --git a/interp/modintern.ml b/interp/modintern.ml
index 166711659f..45e6cd06cd 100644
--- a/interp/modintern.ml
+++ b/interp/modintern.ml
@@ -26,16 +26,16 @@ let error_not_a_module_loc kind loc qid =
     | ModType -> Modops.ModuleTypingError (Modops.NotAModuleType s)
     | ModAny -> ModuleInternalizationError (NotAModuleNorModtype s)
   in
-  Loc.raise ~loc e
+  Loc.raise ?loc e
 
 let error_application_to_not_path loc me =
-  Loc.raise ~loc (Modops.ModuleTypingError (Modops.ApplicationToNotPath me))
+  Loc.raise ?loc (Modops.ModuleTypingError (Modops.ApplicationToNotPath me))
 
 let error_incorrect_with_in_module loc =
-  Loc.raise ~loc (ModuleInternalizationError IncorrectWithInModule)
+  Loc.raise ?loc (ModuleInternalizationError IncorrectWithInModule)
 
 let error_application_to_module_type loc =
-  Loc.raise ~loc (ModuleInternalizationError IncorrectModuleApplication)
+  Loc.raise ?loc (ModuleInternalizationError IncorrectModuleApplication)
 
 (** Searching for a module name in the Nametab.
 
@@ -47,12 +47,12 @@ let lookup_module_or_modtype kind (loc,qid) =
   try
     if kind == ModType then raise Not_found;
     let mp = Nametab.locate_module qid in
-    Dumpglob.dump_modref loc mp "modtype"; (mp,Module)
+    Dumpglob.dump_modref ?loc mp "modtype"; (mp,Module)
   with Not_found ->
     try
       if kind == Module then raise Not_found;
       let mp = Nametab.locate_modtype qid in
-      Dumpglob.dump_modref loc mp "mod"; (mp,ModType)
+      Dumpglob.dump_modref ?loc mp "mod"; (mp,ModType)
     with Not_found -> error_not_a_module_loc kind loc qid
 
 let lookup_module lqid = fst (lookup_module_or_modtype Module lqid)