diff options
| author | Emilio Jesus Gallego Arias | 2017-03-14 18:38:42 +0100 |
|---|---|---|
| committer | Emilio Jesus Gallego Arias | 2017-05-24 11:47:36 +0200 |
| commit | cb316573aa1d09433531e7c67e320c14ef05c3e2 (patch) | |
| tree | 02e9e26f826aace38552372979efb7ff7d9e8ef6 /dev | |
| parent | bf84180f963a31d1ec850d4ccedd599f2984ea9b (diff) | |
[option] Remove support for non-synchronous options.
Inspired by https://coq.inria.fr/bugs/show_bug.cgi?id=5229 , which
this PR solves, I propose to remove support for non-synchronous
options.
It seems the few uses of `optsync = false` we legacy and shouldn't
have any impact.
Moreover, non synchronous options may create particularly tricky
situations as for instance, they won't be propagated to workers.
Diffstat (limited to 'dev')
| -rw-r--r-- | dev/ci/ci-user-overlay.sh | 6 | ||||
| -rw-r--r-- | dev/doc/changes.txt | 7 |
2 files changed, 10 insertions, 3 deletions
diff --git a/dev/ci/ci-user-overlay.sh b/dev/ci/ci-user-overlay.sh index fad6472911..f27d3115e3 100644 --- a/dev/ci/ci-user-overlay.sh +++ b/dev/ci/ci-user-overlay.sh @@ -25,7 +25,7 @@ echo $TRAVIS_PULL_REQUEST echo $TRAVIS_BRANCH echo $TRAVIS_COMMIT -if [ $TRAVIS_PULL_REQUEST == "568" ] || [ $TRAVIS_BRANCH == "remove-tactic-compat" ]; then - fiat_parsers_CI_BRANCH=fix-ml - fiat_parsers_CI_GITURL=https://github.com/ppedrot/fiat.git +if [ $TRAVIS_PULL_REQUEST == "481" ] || [ $TRAVIS_BRANCH == "options+remove_non_sync" ]; then + mathcomp_CI_BRANCH=options+remove_non_sync + mathcomp_CI_GITURL=https://github.com/ejgallego/math-comp.git fi diff --git a/dev/doc/changes.txt b/dev/doc/changes.txt index 8ea1638c99..b5d12d3c7b 100644 --- a/dev/doc/changes.txt +++ b/dev/doc/changes.txt @@ -51,6 +51,13 @@ In Constrexpr_ops: interpreting "(x y z:_)" as "(x:_) (y:_) (z:_)" while the second ones were preserving the original sharing of the type. +In GOption: + + Support for non-synchronous options has been removed. Now all + options are handled as a piece of normal document state, and thus + passed to workers, etc... As a consequence, the field + `Goptions.optsync` has been removed. + ** Tactic API ** - pf_constr_of_global now returns a tactic instead of taking a continuation. |