aboutsummaryrefslogtreecommitdiff
path: root/checker
diff options
context:
space:
mode:
authorGaëtan Gilbert2020-02-24 20:21:13 +0100
committerGaëtan Gilbert2020-04-13 15:18:18 +0200
commit026aaf04abec1042303758783ee23354d2e0fbaa (patch)
treee85502fb1a03f48f70630f8b22c4e35eda0d81b3 /checker
parenta2686239fa742bc761f003608f276a82a4c5cae7 (diff)
always debug validate failures
Diffstat (limited to 'checker')
-rw-r--r--checker/check.ml2
-rw-r--r--checker/validate.ml9
-rw-r--r--checker/validate.mli2
3 files changed, 6 insertions, 7 deletions
diff --git a/checker/check.ml b/checker/check.ml
index bb3255338f..4212aac6ea 100644
--- a/checker/check.ml
+++ b/checker/check.ml
@@ -305,7 +305,7 @@ let marshal_in_segment ~validate ~value f ch =
with _ ->
user_err (str "Corrupted file " ++ quote (str f))
in
- let () = Validate.validate ~debug:!Flags.debug value v in
+ let () = Validate.validate value v in
let v = Analyze.instantiate v in
Obj.obj v, stop, digest
else
diff --git a/checker/validate.ml b/checker/validate.ml
index 66367cb002..20884c4d01 100644
--- a/checker/validate.ml
+++ b/checker/validate.ml
@@ -208,11 +208,10 @@ let print_frame = function
| CtxField i -> Printf.sprintf "fld=%i" i
| CtxTag i -> Printf.sprintf "tag=%i" i
-let validate ~debug v (o, mem) =
+let validate v (o, mem) =
try val_gen v mem mt_ec o
with ValidObjError(msg,ctx,obj) ->
- (if debug then
- let ctx = List.rev_map print_frame ctx in
- print_endline ("Context: "^String.concat"/"ctx);
- pr_obj mem obj);
+ let rctx = List.rev_map print_frame ctx in
+ print_endline ("Context: "^String.concat"/"rctx);
+ pr_obj mem obj;
failwith ("Validation failed: "^msg^" (in "^(print_frame (List.hd ctx))^")")
diff --git a/checker/validate.mli b/checker/validate.mli
index 9ddc510e4a..1204b528f9 100644
--- a/checker/validate.mli
+++ b/checker/validate.mli
@@ -10,4 +10,4 @@
open Analyze
-val validate : debug:bool -> Values.value -> data * obj LargeArray.t -> unit
+val validate : Values.value -> data * obj LargeArray.t -> unit