aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPierre-Marie Pédrot2020-11-10 13:20:15 +0100
committerPierre-Marie Pédrot2020-11-12 10:58:46 +0100
commitaa6d64c7de5d75f1a2625a3ec99c3efc699c5440 (patch)
tree21a63e48649b8217e9875790f49466d92bb3e0fe
parent0ca664107a1e60dfa47aa7536e30a348456efe44 (diff)
Add documentation about the soundness bug.
-rw-r--r--dev/doc/critical-bugs12
-rw-r--r--doc/sphinx/changes.rst7
2 files changed, 19 insertions, 0 deletions
diff --git a/dev/doc/critical-bugs b/dev/doc/critical-bugs
index 066facd5db..37619833ac 100644
--- a/dev/doc/critical-bugs
+++ b/dev/doc/critical-bugs
@@ -312,6 +312,18 @@ Conversion machines
risk: none without using -allow-sprop (off by default in 8.10.0),
otherwise could be exploited by mistake
+Side-effects
+
+ component: side-effects
+ summary: polymorphic side-effects inside monomorphic definitions incorrectly handled as not inlined
+ introduced: ?
+ impacted released versions: at least from 8.6 to 8.12.0
+ impacted coqchk versions: none (no side-effects in the checker)
+ found by: ppedrot
+ exploit: test-suite/bugs/closed/bug_13330.v
+ GH issue number: #13330
+ risk: unlikely to be exploited by mistake, requires the use of unsafe tactics
+
Conflicts with axioms in library
component: library of real numbers
diff --git a/doc/sphinx/changes.rst b/doc/sphinx/changes.rst
index 8da5014125..f1bcd2fb44 100644
--- a/doc/sphinx/changes.rst
+++ b/doc/sphinx/changes.rst
@@ -1224,6 +1224,13 @@ Changes in 8.12.1
<https://github.com/coq/coq/pull/12738>`_, fixes `#7015
<https://github.com/coq/coq/issues/7015>`_, by Gaëtan Gilbert).
+- **Fixed:**
+ Polymorphic side-effects inside monomorphic definitions were incorrectly
+ handled as not inlined. This allowed deriving an inconsistency
+ (`#13331 <https://github.com/coq/coq/pull/13331>`_,
+ fixes `#13330 <https://github.com/coq/coq/issues/13330>`_,
+ by Pierre-Marie Pédrot).
+
**Notations**
- **Fixed:**