diff options
| author | Théo Zimmermann | 2019-08-24 08:50:43 +0200 |
|---|---|---|
| committer | Théo Zimmermann | 2019-08-24 08:51:11 +0200 |
| commit | 7b59d8c9d9b2104de7162ec0e40f6182a6830046 (patch) | |
| tree | 10f3bfc0ea33c9143f86d40bdc1fae5b73f61920 | |
| parent | 07c4c8cac353883a2c6ae493556b9b544f3f38c0 (diff) | |
[gitlab/ci] Prevent Corn from running if Bignums has failed.
The needs keyword needs to include all the transitive dependencies.
Otherwise, we risk stage-3 being skipped but stage-4 being run as in
https://gitlab.com/coq/coq/pipelines/78119475.
The reason why we don't need to include bignums in the dependencies of
corn is because the artifact for math-classes is the directory where
both bignums and math-classes were built.
| -rw-r--r-- | .gitlab-ci.yml | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ce0c1d9af7..e20e0d6981 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -8,8 +8,11 @@ stages: - stage-4 # Only dependencies in stage 1, 2 and 3 - deploy -# When a job has no dependencies, it goes to stage 1. -# Otherwise, we set "needs" and "dependencies" to the same value. +# When a job has no dependencies, it goes to stage 1. Otherwise, we +# set both "needs" and "dependencies". "needs" is a superset of +# "dependencies" that should include all the transitive dependencies. +# "dependencies" only list the previous jobs whose artifact we need to +# keep. # some default values variables: @@ -654,6 +657,7 @@ library:ci-corn: stage: stage-4 needs: - build:edge+flambda + - plugin:ci-bignums - library:ci-math-classes dependencies: - build:edge+flambda |