diff options
| author | Maxime Dénès | 2019-04-04 00:28:15 +0200 |
|---|---|---|
| committer | Maxime Dénès | 2019-04-05 21:16:14 +0200 |
| commit | 44a669e591ee00bcea65b229429dcb5d4d3515ec (patch) | |
| tree | d3b631c15fef018d8ca87fe4db92f92bc51d3e71 | |
| parent | 73e7bbab4ff6120318ec7b90e4971bfafd09cfb5 (diff) | |
[native compiler] Fix critical bug with primitive projections
Since e1e7888, stuck projections were not computed correctly.
Fixes #9684
| -rw-r--r-- | dev/doc/critical-bugs | 9 | ||||
| -rw-r--r-- | kernel/nativecode.ml | 2 | ||||
| -rw-r--r-- | test-suite/bugs/closed/bug_9684.v | 19 |
3 files changed, 29 insertions, 1 deletions
diff --git a/dev/doc/critical-bugs b/dev/doc/critical-bugs index c0a5b9095c..f532e1b68f 100644 --- a/dev/doc/critical-bugs +++ b/dev/doc/critical-bugs @@ -207,6 +207,15 @@ Conversion machines GH issue number: ? risk: + component: primitive projections, native_compute + summary: stuck primitive projections computed incorrectly by native_compute + introduced: 1 Jun 2018, e1e7888a, ppedrot + impacted released versions: 8.9.0 + impacted coqchk versions: none + found by: maximedenes exploiting bug #9684 + exploit: test-suite/bugs/closed/bug_9684.v + GH issue number: #9684 + Conflicts with axioms in library component: library of real numbers diff --git a/kernel/nativecode.ml b/kernel/nativecode.ml index 2dab14e732..94ed288d2d 100644 --- a/kernel/nativecode.ml +++ b/kernel/nativecode.ml @@ -1958,7 +1958,7 @@ let compile_mind mb mind stack = let cargs = Array.init arity (fun i -> if Int.equal i proj_arg then Some ci_uid else None) in - let i = push_symbol (SymbProj (ind, j)) in + let i = push_symbol (SymbProj (ind, proj_arg)) in let accu = MLapp (MLprimitive Cast_accu, [|MLlocal cf_uid|]) in let accu_br = MLapp (MLprimitive Mk_proj, [|get_proj_code i;accu|]) in let code = MLmatch(asw,MLlocal cf_uid,accu_br,[|[((ind,1),cargs)],MLlocal ci_uid|]) in diff --git a/test-suite/bugs/closed/bug_9684.v b/test-suite/bugs/closed/bug_9684.v new file mode 100644 index 0000000000..436a00585b --- /dev/null +++ b/test-suite/bugs/closed/bug_9684.v @@ -0,0 +1,19 @@ +Set Primitive Projections. + +Record foo := mkFoo { proj1 : bool; proj2 : bool }. + +Definition x := mkFoo true false. +Definition proj x := proj2 x. + +Lemma oops : proj = fun x => proj1 x. +Proof. Fail native_compute; reflexivity. Abort. + +(* +Lemma bad : False. +assert (proj1 x = proj x). + rewrite oops; reflexivity. +discriminate. +Qed. + +Print Assumptions bad. +*) |