1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
|
// SPDX-License-Identifier: Apache-2.0
package chiselTests.naming
import chisel3._
import chisel3.stage.ChiselStage
import chisel3.aop.Select
import chisel3.experimental.{dump, noPrefix, prefix, treedump}
import chiselTests.{ChiselPropSpec, Utils}
import chisel3.experimental.AffectsChiselPrefix
class PrefixSpec extends ChiselPropSpec with Utils {
implicit val minimumMajorVersion: Int = 12
property("Scala plugin should interact with prefixing so last plugin name wins?") {
class Test extends Module {
def builder(): UInt = {
val wire1 = Wire(UInt(3.W))
val wire2 = Wire(UInt(3.W))
wire2
}
{
val x1 = prefix("first") {
builder()
}
}
{
val x2 = prefix("second") {
builder()
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("x1_first_wire1", "x1", "x2_second_wire1", "x2"))
}
}
property("Nested prefixes should work") {
class Test extends Module {
def builder2(): UInt = {
val wire1 = Wire(UInt(3.W))
val wire2 = Wire(UInt(3.W))
wire2
}
def builder(): UInt = {
val wire1 = Wire(UInt(3.W))
val wire2 = Wire(UInt(3.W))
prefix("foo") {
builder2()
}
}
{ val x1 = builder() }
{ val x2 = builder() }
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(
List(
"x1_wire1",
"x1_wire2",
"x1_foo_wire1",
"x1",
"x2_wire1",
"x2_wire2",
"x2_foo_wire1",
"x2"
)
)
}
}
property("Prefixing seeded with signal") {
class Test extends Module {
def builder(): UInt = {
val wire = Wire(UInt(3.W))
wire := 3.U
wire
}
{
val x1 = Wire(UInt(3.W))
x1 := {
builder()
}
val x2 = Wire(UInt(3.W))
x2 := {
builder()
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("x1", "x1_wire", "x2", "x2_wire"))
}
}
property("Automatic prefixing should work") {
class Test extends Module {
def builder(): UInt = {
val a = Wire(UInt(3.W))
val b = Wire(UInt(3.W))
b
}
{
val ADAM = builder()
val JACOB = builder()
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("ADAM_a", "ADAM", "JACOB_a", "JACOB"))
}
}
property("No prefixing annotation on defs should work") {
class Test extends Module {
def builder(): UInt = noPrefix {
val a = Wire(UInt(3.W))
val b = Wire(UInt(3.W))
b
}
{ val noprefix = builder() }
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("a", "noprefix"))
}
}
property("Prefixing on temps should work") {
class Test extends Module {
def builder(): UInt = {
val a = Wire(UInt(3.W))
val b = Wire(UInt(3.W))
a +& (b * a)
}
{ val blah = builder() }
}
aspectTest(() => new Test) { top: Test =>
Select.ops(top).map(x => (x._1, x._2.instanceName)) should be(
List(
("mul", "_blah_T"),
("add", "blah")
)
)
}
}
property("Prefixing should not leak into child modules") {
class Child extends Module {
{
val wire = Wire(UInt())
}
}
class Test extends Module {
{
val child = prefix("InTest") {
Module(new Child)
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(Select.instances(top).head).map(_.instanceName) should be(List("wire"))
}
}
property("Prefixing should not leak into child modules, example 2") {
class Child extends Module {
{
val wire = Wire(UInt())
}
}
class Test extends Module {
val x = IO(Input(UInt(3.W)))
val y = {
lazy val module = new Child
val child = Module(module)
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(Select.instances(top).head).map(_.instanceName) should be(List("wire"))
}
}
property("Instance names should not be added to prefix") {
class Child(tpe: UInt) extends Module {
{
val io = IO(Input(tpe))
}
}
class Test extends Module {
{
lazy val module = {
val x = UInt(3.W)
new Child(x)
}
val child = Module(module)
}
}
aspectTest(() => new Test) { top: Test =>
Select.ios(Select.instances(top).head).map(_.instanceName) should be(List("clock", "reset", "io"))
}
}
property("Prefixing should not be caused by nested Iterable[Iterable[Any]]") {
class Test extends Module {
{
val iia = {
val wire = Wire(UInt(3.W))
List(List("Blah"))
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("wire"))
}
}
property("Prefixing should be caused by nested Iterable[Iterable[Data]]") {
class Test extends Module {
{
val iia = {
val wire = Wire(UInt(3.W))
List(List(3.U))
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("iia_wire"))
}
}
property("Prefixing should NOT be influenced by suggestName") {
class Test extends Module {
{
val wire = {
val x = Wire(UInt(3.W)) // wire_x
Wire(UInt(3.W)).suggestName("foo")
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("wire_x", "foo"))
}
}
property("Prefixing should be influenced by the \"current name\" of the signal") {
class Test extends Module {
{
val wire = {
val y = Wire(UInt(3.W)).suggestName("foo")
val x = Wire(UInt(3.W)) // wire_x
y
}
val wire2 = Wire(UInt(3.W))
wire2 := {
val x = Wire(UInt(3.W)) // wire2_x
x + 1.U
}
wire2.suggestName("bar")
val wire3 = Wire(UInt(3.W))
wire3.suggestName("fizz")
wire3 := {
val x = Wire(UInt(3.W)) // fizz_x
x + 1.U
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("foo", "wire_x", "bar", "wire2_x", "fizz", "fizz_x"))
}
}
property("Prefixing have intuitive behavior") {
class Test extends Module {
{
val wire = {
val x = Wire(UInt(3.W)).suggestName("mywire")
val y = Wire(UInt(3.W)).suggestName("mywire2")
y := x
y
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("wire_mywire", "mywire2"))
}
}
property("Prefixing on connection to subfields work") {
class Test extends Module {
{
val wire = Wire(new Bundle {
val x = UInt(3.W)
val y = UInt(3.W)
val vec = Vec(4, UInt(3.W))
})
wire.x := RegNext(3.U)
wire.y := RegNext(3.U)
wire.vec(0) := RegNext(3.U)
wire.vec(wire.x) := RegNext(3.U)
wire.vec(1.U) := RegNext(3.U)
}
}
aspectTest(() => new Test) { top: Test =>
Select.registers(top).map(_.instanceName) should be(
List(
"wire_x_REG",
"wire_y_REG",
"wire_vec_0_REG",
"wire_vec_REG",
"wire_vec_1_REG"
)
)
}
}
property("Prefixing on connection to IOs should work") {
class Child extends Module {
val in = IO(Input(UInt(3.W)))
val out = IO(Output(UInt(3.W)))
out := RegNext(in)
}
class Test extends Module {
{
val child = Module(new Child)
child.in := RegNext(3.U)
}
}
aspectTest(() => new Test) { top: Test =>
Select.registers(top).map(_.instanceName) should be(
List(
"child_in_REG"
)
)
Select.registers(Select.instances(top).head).map(_.instanceName) should be(
List(
"out_REG"
)
)
}
}
property("Prefixing on bulk connects should work") {
class Child extends Module {
val in = IO(Input(UInt(3.W)))
val out = IO(Output(UInt(3.W)))
out := RegNext(in)
}
class Test extends Module {
{
val child = Module(new Child)
child.in <> RegNext(3.U)
}
}
aspectTest(() => new Test) { top: Test =>
Select.registers(top).map(_.instanceName) should be(
List(
"child_in_REG"
)
)
Select.registers(Select.instances(top).head).map(_.instanceName) should be(
List(
"out_REG"
)
)
}
}
property("Connections should use the non-prefixed name of the connected Data") {
class Test extends Module {
prefix("foo") {
val x = Wire(UInt(8.W))
x := {
val w = Wire(UInt(8.W))
w := 3.U
w + 1.U
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("foo_x", "foo_x_w"))
}
}
property("Connections to aggregate fields should use the non-prefixed aggregate name") {
class Test extends Module {
prefix("foo") {
val x = Wire(new Bundle { val bar = UInt(8.W) })
x.bar := {
val w = Wire(new Bundle { val fizz = UInt(8.W) })
w.fizz := 3.U
w.fizz + 1.U
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("foo_x", "foo_x_bar_w"))
}
}
property("Prefixing with wires in recursive functions should grow linearly") {
class Test extends Module {
def func(bools: Seq[Bool]): Bool = {
if (bools.isEmpty) true.B
else {
val w = Wire(Bool())
w := bools.head && func(bools.tail)
w
}
}
val in = IO(Input(Vec(4, Bool())))
val x = func(in)
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("x", "x_w_w", "x_w_w_w", "x_w_w_w_w"))
}
}
property("Prefixing should work for verification ops") {
class Test extends Module {
val foo, bar = IO(Input(UInt(8.W)))
{
val x5 = {
val x1 = chisel3.assert(1.U === 1.U)
val x2 = cover(foo =/= bar)
val x3 = chisel3.assume(foo =/= 123.U)
val x4 = printf("foo = %d\n", foo)
x1
}
}
}
val chirrtl = ChiselStage.emitChirrtl(new Test)
(chirrtl should include).regex("assert.*: x5")
(chirrtl should include).regex("cover.*: x5_x2")
(chirrtl should include).regex("assume.*: x5_x3")
(chirrtl should include).regex("printf.*: x5_x4")
}
property("Leading '_' in val names should be ignored in prefixes") {
class Test extends Module {
{
val a = {
val _b = {
val c = Wire(UInt(3.W))
4.U // literal because there is no name
}
_b
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("a_b_c"))
}
}
// This checks that we don't just blanket ignore leading _ in prefixes
property("User-specified prefixes with '_' should be respected") {
class Test extends Module {
{
val a = {
val _b = prefix("_b") {
val c = Wire(UInt(3.W))
}
4.U
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("a__b_c"))
}
}
property("Leading '_' in signal names should be ignored in prefixes from connections") {
class Test extends Module {
{
val a = {
val b = {
val _c = IO(Output(UInt(3.W))) // port so not selected as wire
_c := {
val d = Wire(UInt(3.W))
d
}
4.U // literal so there is no name
}
b
}
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("a_b_c_d"))
}
}
property("Prefixing of AffectsChiselPrefix objects should work") {
class NotAData extends AffectsChiselPrefix {
val value = Wire(UInt(3.W))
}
class NotADataUnprefixed {
val value = Wire(UInt(3.W))
}
class Test extends Module {
{
val nonData = new NotAData
// Instance name of nonData.value should be nonData_value
nonData.value := RegNext(3.U)
val nonData2 = new NotADataUnprefixed
// Instance name of nonData2.value should be value
nonData2.value := RegNext(3.U)
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("nonData_value", "value"))
}
}
property("Prefixing should not be affected by repeated calls of suggestName") {
class Test extends Module {
val in = IO(Input(UInt(3.W)))
val prefixed = {
val wire = Wire(UInt(3.W)).suggestName("wire") // "prefixed_wire"
wire := in
val thisShouldNotBeHere = {
// Second suggestName doesn't modify the instanceName since it was
// already suggested, but also should not modify the prefix either
// Incorrect behavior would rename the wire to
// "prefixed_thisShouldNotBeHere_wire"
wire.suggestName("wire")
val out = IO(Output(UInt(3.W)))
out := wire
out
}
thisShouldNotBeHere
}
}
aspectTest(() => new Test) { top: Test =>
Select.wires(top).map(_.instanceName) should be(List("prefixed_wire"))
}
}
}
|