Throw exceptions for cloneType failures - fix #358

Add a Builder.exception() method for those cases where continuing is likely to mask the initial error.

1 files changed, 57 insertions, 0 deletions

diff --git a/src/test/scala/chiselTests/MissingCloneBindingExceptionSpec.scala b/src/test/scala/chiselTests/MissingCloneBindingExceptionSpec.scala
new file mode 100644
index 00000000..fd48206e
--- /dev/null
+++ b/src/test/scala/chiselTests/MissingCloneBindingExceptionSpec.scala
@@ -0,0 +1,57 @@
+// See LICENSE for license details.
+
+package chiselTests
+import Chisel.ChiselException
+import org.scalatest._
+
+class MissingCloneBindingExceptionSpec extends FlatSpec with Matchers {
+  behavior of "missing cloneType in Chisel3"
+  ( the[ChiselException] thrownBy {
+    import chisel3._
+
+    class TestIO(w: Int) extends Bundle {
+      val a = Vec(4, UInt(width = w)).asInput
+
+      //override def cloneType = (new TestIO(w)).asInstanceOf[this.type]
+    }
+
+    class Test extends Module {
+      val io = IO(new TestIO(32))
+    }
+
+    class TestTop extends Module {
+      val io = IO(new Bundle {})
+
+      val subs = Vec.fill(2) {
+        Module(new Test).io
+      }
+    }
+
+    val dummy = new TestTop
+  }).getMessage should include("needs cloneType method")
+
+  behavior of "missing cloneType in Chisel2"
+  ( the[ChiselException] thrownBy {
+    import Chisel._
+
+    class TestIO(w: Int) extends Bundle {
+      val a = Vec(4, UInt(width = w)).asInput
+
+      //override def cloneType = (new TestIO(w)).asInstanceOf[this.type]
+    }
+
+    class Test extends Module {
+      val io = IO(new TestIO(32))
+    }
+
+    class TestTop extends Module {
+      val io = IO(new Bundle {})
+
+      val subs = Vec.fill(2) {
+        Module(new Test).io
+      }
+    }
+
+    val dummy = new TestTop
+  }).getMessage should include("needs cloneType method")
+}