From a076a8ec18bdda6f8a964bea7f91d32cb17f0b89 Mon Sep 17 00:00:00 2001 From: Andrew Waterman Date: Tue, 26 Mar 2019 12:11:35 -0700 Subject: DCE printf and stop statements with constant-0 enables This gets rid of about 10% of the generated Verilog in the rocket-chip default config. --- src/main/scala/firrtl/transforms/DeadCodeElimination.scala | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src') diff --git a/src/main/scala/firrtl/transforms/DeadCodeElimination.scala b/src/main/scala/firrtl/transforms/DeadCodeElimination.scala index 8f9fad46..deb7299d 100644 --- a/src/main/scala/firrtl/transforms/DeadCodeElimination.scala +++ b/src/main/scala/firrtl/transforms/DeadCodeElimination.scala @@ -212,6 +212,11 @@ class DeadCodeElimination extends Transform with ResolvedAnnotationPaths with Re var emptyBody = true renames.setModule(mod.name) + def deleteIfNotEnabled(stmt: Statement, en: Expression): Statement = en match { + case UIntLiteral(v, _) if v == BigInt(0) => EmptyStmt + case _ => stmt + } + def onStmt(stmt: Statement): Statement = { val stmtx = stmt match { case inst: WDefInstance => @@ -230,6 +235,8 @@ class DeadCodeElimination extends Transform with ResolvedAnnotationPaths with Re EmptyStmt } else decl + case print: Print => deleteIfNotEnabled(print, print.en) + case stop: Stop => deleteIfNotEnabled(stop, stop.en) case con: Connect => val node = getDeps(con.loc) match { case Seq(elt) => elt } if (deadNodes.contains(node)) EmptyStmt else con -- cgit v1.2.3 From 24f81e828b70e2745c2fbd06a4694a9f054851e8 Mon Sep 17 00:00:00 2001 From: Andrew Waterman Date: Tue, 26 Mar 2019 12:00:03 -0700 Subject: Add test for DCE of printf and stop --- src/test/scala/firrtlTests/DCETests.scala | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'src') diff --git a/src/test/scala/firrtlTests/DCETests.scala b/src/test/scala/firrtlTests/DCETests.scala index a6def402..620cc5f3 100644 --- a/src/test/scala/firrtlTests/DCETests.scala +++ b/src/test/scala/firrtlTests/DCETests.scala @@ -449,6 +449,23 @@ class DCETests extends FirrtlFlatSpec { // Check for register update verilog should include regex ("""(?m)if \(a\) begin\n\s*r <= x;\s*end""") } + + "Emitted Verilog" should "not contain dead print or stop statements" in { + val input = parse( + """circuit test : + | module test : + | input clock : Clock + | when UInt<1>(0) : + | printf(clock, UInt<1>(1), "o hai") + | stop(clock, UInt<1>(1), 1)""".stripMargin + ) + + val state = CircuitState(input, ChirrtlForm) + val result = (new VerilogCompiler).compileAndEmit(state, List.empty) + val verilog = result.getEmittedCircuit.value + verilog shouldNot include regex ("""fwrite""") + verilog shouldNot include regex ("""fatal""") + } } class DCECommandLineSpec extends FirrtlFlatSpec { -- cgit v1.2.3