From 5d7bbb2e42b19762a6408f3d9c4925a5eba37f76 Mon Sep 17 00:00:00 2001 From: Jack Koenig Date: Tue, 12 Jun 2018 14:42:00 -0700 Subject: Deprecate SingleStringAnnotation (#811) It does not provide anything over NoTargetAnnotation. Its existence suggests some significance so removing it for clarity.--- src/main/scala/firrtl/ExecutionOptionsManager.scala | 2 +- src/main/scala/firrtl/annotations/Annotation.scala | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/main/scala/firrtl/ExecutionOptionsManager.scala b/src/main/scala/firrtl/ExecutionOptionsManager.scala index c5f3506a..b359ba5e 100644 --- a/src/main/scala/firrtl/ExecutionOptionsManager.scala +++ b/src/main/scala/firrtl/ExecutionOptionsManager.scala @@ -69,7 +69,7 @@ case class CommonOptions( } /** Annotation that contains the [[CommonOptions]] target directory */ -case class TargetDirAnnotation(value: String) extends SingleStringAnnotation +case class TargetDirAnnotation(value: String) extends NoTargetAnnotation trait HasCommonOptions { self: ExecutionOptionsManager => diff --git a/src/main/scala/firrtl/annotations/Annotation.scala b/src/main/scala/firrtl/annotations/Annotation.scala index b16509a1..4b0591bf 100644 --- a/src/main/scala/firrtl/annotations/Annotation.scala +++ b/src/main/scala/firrtl/annotations/Annotation.scala @@ -51,6 +51,7 @@ trait SingleTargetAnnotation[T <: Named] extends Annotation { })).getOrElse(List(this)) } +@deprecated("Just extend NoTargetAnnotation", "1.1") trait SingleStringAnnotation extends NoTargetAnnotation { def value: String } -- cgit v1.2.3