From 04f4bc177f8d38993a191bdba4398840a2a63155 Mon Sep 17 00:00:00 2001
From: Albert Magyar
Date: Wed, 15 Apr 2020 16:22:00 -0700
Subject: Remove repetitive pass lists from WidthTests

---
 src/test/scala/firrtlTests/WidthSpec.scala | 75 +++++++-----------------------
 1 file changed, 18 insertions(+), 57 deletions(-)

(limited to 'src')

diff --git a/src/test/scala/firrtlTests/WidthSpec.scala b/src/test/scala/firrtlTests/WidthSpec.scala
index c5e3834e..4d04ed66 100644
--- a/src/test/scala/firrtlTests/WidthSpec.scala
+++ b/src/test/scala/firrtlTests/WidthSpec.scala
@@ -18,6 +18,17 @@ class WidthSpec extends FirrtlFlatSpec {
     }
   }
 
+  private val inferPasses = Seq(
+    ToWorkingIR,
+    CheckHighForm,
+    ResolveKinds,
+    InferTypes,
+    CheckTypes,
+    ResolveFlows,
+    new InferWidths)
+
+  private val inferAndCheckPasses = inferPasses :+ CheckWidths
+
   case class LiteralWidthCheck(lit: BigInt, uIntWidth: Option[BigInt], sIntWidth: BigInt)
   val litChecks = Seq(
     LiteralWidthCheck(-4, None, 3),
@@ -43,15 +54,6 @@ class WidthSpec extends FirrtlFlatSpec {
   }
 
   "Dshl by 20 bits" should "result in an error" in {
-    val passes = Seq(
-      ToWorkingIR,
-      CheckHighForm,
-      ResolveKinds,
-      InferTypes,
-      CheckTypes,
-      ResolveFlows,
-      new InferWidths,
-      CheckWidths)
     val input =
       """circuit Unit :
         |  module Unit :
@@ -62,38 +64,21 @@ class WidthSpec extends FirrtlFlatSpec {
     // Throws both DshlTooBig and WidthTooBig
     // TODO check message
     intercept[PassExceptions] {
-      executeTest(input, Nil, passes)
+      executeTest(input, Nil, inferAndCheckPasses)
     }
   }
+
   "Width >= MaxWidth" should "result in an error" in {
-    val passes = Seq(
-      ToWorkingIR,
-      CheckHighForm,
-      ResolveKinds,
-      InferTypes,
-      CheckTypes,
-      ResolveFlows,
-      new InferWidths,
-      CheckWidths)
     val input =
      s"""circuit Unit :
         |  module Unit :
         |    input x: UInt<${CheckWidths.MaxWidth}>
       """.stripMargin
     intercept[CheckWidths.WidthTooBig] {
-      executeTest(input, Nil, passes)
+      executeTest(input, Nil, inferAndCheckPasses)
     }
   }
   "Circular reg depending on reg + 1" should "error" in {
-    val passes = Seq(
-      ToWorkingIR,
-      CheckHighForm,
-      ResolveKinds,
-      InferTypes,
-      CheckTypes,
-      ResolveFlows,
-      new InferWidths,
-      CheckWidths)
     val input =
       """circuit Unit :
         |  module Unit :
@@ -105,19 +90,11 @@ class WidthSpec extends FirrtlFlatSpec {
         |    r <= T_7
         |""".stripMargin
     intercept[CheckWidths.UninferredWidth] {
-      executeTest(input, Nil, passes)
+      executeTest(input, Nil, inferAndCheckPasses)
     }
   }
 
   "Add of UInt<2> and SInt<2>" should "error" in {
-    val passes = Seq(
-      ToWorkingIR,
-      CheckHighForm,
-      ResolveKinds,
-      InferTypes,
-      CheckTypes,
-      ResolveFlows,
-      new InferWidths)
     val input =
       """circuit Unit :
         |  module Unit :
@@ -127,19 +104,11 @@ class WidthSpec extends FirrtlFlatSpec {
         |    z <= add(x, y)""".stripMargin
     val check = Seq( "output z : SInt<4>")
     intercept[PassExceptions] {
-      executeTest(input, check, passes)
+      executeTest(input, check, inferPasses)
     }
   }
 
   "SInt<2> - UInt<3>" should "error" in {
-    val passes = Seq(
-      ToWorkingIR,
-      CheckHighForm,
-      ResolveKinds,
-      InferTypes,
-      CheckTypes,
-      ResolveFlows,
-      new InferWidths)
     val input =
       """circuit Unit :
         |  module Unit :
@@ -149,21 +118,13 @@ class WidthSpec extends FirrtlFlatSpec {
         |    z <= sub(y, x)""".stripMargin
     val check = Seq( "output z : SInt<5>")
     intercept[PassExceptions] {
-      executeTest(input, check, passes)
+      executeTest(input, check, inferPasses)
     }
   }
 
   behavior of "CheckWidths.UniferredWidth"
 
   it should "provide a good error message with a full target if a user forgets an assign" in {
-    val passes = Seq(
-      ToWorkingIR,
-      ResolveKinds,
-      InferTypes,
-      CheckTypes,
-      ResolveFlows,
-      new InferWidths,
-      CheckWidths)
     val input =
       """|circuit Foo :
          |  module Foo :
@@ -172,7 +133,7 @@ class WidthSpec extends FirrtlFlatSpec {
          |  module Bar :
          |    wire a: { b : UInt<1>, c : { d : UInt<1>, e : UInt } }
          |""".stripMargin
-    val msg = intercept[CheckWidths.UninferredWidth] { executeTest(input, Nil, passes) }
+    val msg = intercept[CheckWidths.UninferredWidth] { executeTest(input, Nil, inferAndCheckPasses) }
       .getMessage should include ("""|    circuit Foo:
                                      |    └── module Bar:
                                      |        └── a.c.e""".stripMargin)
-- 
cgit v1.2.3