From 1bb38863914a1c8b11f2a4587638d8f8603ae8f4 Mon Sep 17 00:00:00 2001
From: Albert Magyar
Date: Mon, 13 Apr 2020 23:29:36 -0700
Subject: Avoid infinite loops on async-reset self-inits in CheckResets

* Fixes #1516
* Tighten up logic for "casted literal" checking
---
 src/main/scala/firrtl/checks/CheckResets.scala | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

(limited to 'src')

diff --git a/src/main/scala/firrtl/checks/CheckResets.scala b/src/main/scala/firrtl/checks/CheckResets.scala
index facd5c01..4f7f7060 100644
--- a/src/main/scala/firrtl/checks/CheckResets.scala
+++ b/src/main/scala/firrtl/checks/CheckResets.scala
@@ -47,6 +47,7 @@ class CheckResets extends Transform with PreservesAll[Transform] {
     stmt match {
       case DefNode(_, name, expr) => drivers += we(WRef(name)) -> expr
       case Connect(_, lhs, rhs) => drivers += we(lhs) -> rhs
+      case reg @ DefRegister(_, name, _,_,_, init) if weq(WRef(name), init) => // Self-reset, allowed!
       case reg @ DefRegister(_,_,_,_, reset, init) if reset.tpe == AsyncResetType =>
         regCheck += init -> reg
       case _ => // Do nothing
@@ -54,14 +55,16 @@ class CheckResets extends Transform with PreservesAll[Transform] {
     stmt.foreach(onStmt(regCheck, drivers))
   }
 
+  private def wireOrNode(kind: Kind) = (kind == WireKind || kind == NodeKind)
+
   @tailrec
   private def findDriver(drivers: DirectDriverMap)(expr: Expression): Expression = expr match {
-     case lit: Literal => lit
-     case DoPrim(op, args, _,_) if isCast(op) => findDriver(drivers)(args.head)
-     case other => drivers.get(we(other)) match {
-       case Some(e) => findDriver(drivers)(e)
-       case None => other
-     }
+    case lit: Literal => lit
+    case DoPrim(op, args, _,_) if isCast(op) => findDriver(drivers)(args.head)
+    case other => drivers.get(we(other)) match {
+      case Some(e) if wireOrNode(Utils.kind(other)) => findDriver(drivers)(e)
+      case _ => other
+    }
   }
 
   private def onMod(errors: Errors)(mod: DefModule): Unit = {
-- 
cgit v1.2.3


From 74ff30cf8dcfb7253458905b626dee89fc9b280c Mon Sep 17 00:00:00 2001
From: Albert Magyar
Date: Mon, 13 Apr 2020 23:30:41 -0700
Subject: Add Paul's async-reset self-init case as a test

---
 src/test/scala/firrtlTests/AsyncResetSpec.scala | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

(limited to 'src')

diff --git a/src/test/scala/firrtlTests/AsyncResetSpec.scala b/src/test/scala/firrtlTests/AsyncResetSpec.scala
index 60eab883..34211946 100644
--- a/src/test/scala/firrtlTests/AsyncResetSpec.scala
+++ b/src/test/scala/firrtlTests/AsyncResetSpec.scala
@@ -117,6 +117,20 @@ class AsyncResetSpec extends FirrtlFlatSpec {
     }
   }
 
+  "Self-inits" should "NOT cause infinite loops in CheckResets" in {
+    val result = compileBody(s"""
+        |input clock : Clock
+        |input reset : AsyncReset
+        |input in : UInt<12>
+        |output out : UInt<10>
+        |
+        |reg a : UInt<10>, clock with :
+        |  reset => (reset, a)
+        |out <= UInt<5>("h15")""".stripMargin
+      )
+    result should containLine("assign out = 10'h15;")
+  }
+
   "Late non-literals connections" should "NOT be allowed as reset values for AsyncReset" in {
     an [checks.CheckResets.NonLiteralAsyncResetValueException] shouldBe thrownBy {
       compileBody(s"""
-- 
cgit v1.2.3