From ef1d27a84addc46353884eb06ea18f4c68e6a808 Mon Sep 17 00:00:00 2001 From: Jack Koenig Date: Fri, 8 Oct 2021 17:09:55 -0700 Subject: Support parsing missing keywords as ids (#2381) Reset, AsyncReset, Interval, attach, assert, assume, and cover have all been added as keywords but not added to the allowlist for parsing as ids.--- src/test/scala/firrtlTests/ParserSpec.scala | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) (limited to 'src/test') diff --git a/src/test/scala/firrtlTests/ParserSpec.scala b/src/test/scala/firrtlTests/ParserSpec.scala index ba61b134..5183a6f2 100644 --- a/src/test/scala/firrtlTests/ParserSpec.scala +++ b/src/test/scala/firrtlTests/ParserSpec.scala @@ -48,8 +48,11 @@ class ParserSpec extends FirrtlFlatSpec { "SInt", "Analog", "Fixed", + "Interval", "flip", "Clock", + "Reset", + "AsyncReset", "wire", "reg", "reset", @@ -80,7 +83,11 @@ class ParserSpec extends FirrtlFlatSpec { "infer", "read", "write", - "rdwr" + "rdwr", + "attach", + "assert", + "assume", + "cover" ) ++ PrimOps.listing } @@ -183,6 +190,15 @@ class ParserSpec extends FirrtlFlatSpec { } } + they should "be allowed as names for side effecting statements" in { + import KeywordTests._ + keywords.foreach { keyword => + firrtl.Parser.parse { + prelude :+ s""" assert($keyword, UInt(1), UInt(1), "") : $keyword""" + } + } + } + // ********** Digits as Fields ********** "Digits" should "be legal fields in bundles and in subexpressions" in { val input = """ -- cgit v1.2.3