From 1937cfd58c070774e53e5bffc22bac779f338cdd Mon Sep 17 00:00:00 2001 From: Adam Izraelevitz Date: Tue, 11 Feb 2020 16:41:58 -0800 Subject: Add reviewer checklist / update contributor checklist (#1375) * Add reviewer checklist / update contributor checklist * Update PULL_REQUEST_TEMPLATE.md Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> --- .github/PULL_REQUEST_TEMPLATE.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 9c462b3e..0edc672b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,8 @@ -### Checklist +### Contributor Checklist +- [ ] Did you add Scaladoc to every public function/method? +- [ ] Did you add at least one test demonstrating the PR? +- [ ] Did you delete any extraneous printlns/debugging code? - [ ] Did you specify the type of improvement? - [ ] Did you state the API impact? - [ ] Did you specify the code generation impact? @@ -31,3 +34,9 @@ + +### Reviewer Checklist (only modified by reviewer) +- [ ] Did you add the appropriate labels? +- [ ] Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ? +- [ ] Did you review? +- [ ] Did you mark as `Please Merge`? -- cgit v1.2.3