diff options
| author | Albert Chen | 2020-07-23 14:31:11 -0700 |
|---|---|---|
| committer | GitHub | 2020-07-23 21:31:11 +0000 |
| commit | e30c20d10ba47b11e06416e912ed89b6b6ce8e7b (patch) | |
| tree | d64b76b035c22a924eca42b7c91e0db56b99e987 /src/main/scala/firrtl/transforms | |
| parent | 1927dc6574b9eee315c8f24441df390f2ce793c7 (diff) | |
fix reduction op bug ConstantPropagation (#1746)
* add const prop bitwise reduction equivalence test
* mask negative literals when propagating reduction
* change widths
* get rid of unnecessary if
* add BigInt mask utility
Diffstat (limited to 'src/main/scala/firrtl/transforms')
| -rw-r--r-- | src/main/scala/firrtl/transforms/ConstantPropagation.scala | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/main/scala/firrtl/transforms/ConstantPropagation.scala b/src/main/scala/firrtl/transforms/ConstantPropagation.scala index 8ad3489f..0ec4fe0b 100644 --- a/src/main/scala/firrtl/transforms/ConstantPropagation.scala +++ b/src/main/scala/firrtl/transforms/ConstantPropagation.scala @@ -160,7 +160,8 @@ class ConstantPropagation extends Transform with DependencyAPIMigration with Res case IntWidth(b) => b } - val v: Seq[Boolean] = s"%${w}s".format(a.value.toString(2)).map(_ == '1') + val maskedValue = Utils.maskBigInt(a.value, w.toInt) + val v: Seq[Boolean] = s"%${w}s".format(maskedValue.toString(2)).map(_ == '1') (BigInt(0) until w).zip(v).foldLeft(identityValue) { case (acc, (_, x)) => reduce(acc, x) |