sfcX/src/test/scala/firrtlTests/transforms, branch 1.6.x Scala FIRRTL Compiler for chiselX Fix optimization of register with reset but invalid connection (#2520) 2022-04-22T03:20:47+00:00 Jack Koenig 2022-04-22T03:20:47+00:00 5093da03083a37a0a7bdaf44f9867d7f7a0a5980 Fixes #2516 Previously, reg r : UInt<8>, clock with : reset => (p, UInt<8>(3)) r is invalid would compile to: reg r : UInt<8>, clock r <= UInt<8>(0) now it compiles to: reg r : UInt<8>, clock wire r_1 : UInt<8> r_1 is invalid r <= mux(reset, UInt<8>(3), r_1) This is consistent with the behavior for a reset with an asynchronous reset. 
Fixes #2516

Previously,

reg r : UInt<8>, clock with :
  reset => (p, UInt<8>(3))
r is invalid

would compile to:

reg r : UInt<8>, clock
r <= UInt<8>(0)

now it compiles to:

reg r : UInt<8>, clock
wire r_1 : UInt<8>
r_1 is invalid
r <= mux(reset, UInt<8>(3), r_1)

This is consistent with the behavior for a reset with an asynchronous
reset.
 Deprecate all mutable methods on RenameMap (#2444) 2021-12-17T18:07:25+00:00 Jack Koenig 2021-12-17T18:07:25+00:00 37c8528cfed4395924820b54498ef761ded17393 * Add renamemap.MutableRenameMap which includes these methods without deprecation * Deprecate Stringly typed RenameMap APIs which were accidentally undeprecated a while ago Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> 
* Add renamemap.MutableRenameMap which includes these methods without
  deprecation
* Deprecate Stringly typed RenameMap APIs which were accidentally
  undeprecated a while ago

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 Implement CustomRadixTransform for wave viewers (#2434) 2021-12-13T18:50:28+00:00 Jiuyang Liu 2021-12-13T18:50:28+00:00 7f884493073248576e896163dda350c997dd4ff2 1. Add CustomRadix{Def,Apply}Annotation to define and apply custom radix. 2. Add CustomRadixConfigFileAnnotation to output a JSON config file so users can generate scripts on their own. Reviewed-by: Jiuyang Liu <liu@jiuyang.me> Co-authored-by: sinofp <sinofp@tuta.io> 
1. Add CustomRadix{Def,Apply}Annotation to define and apply custom radix.
2. Add CustomRadixConfigFileAnnotation to output a JSON config file so
   users can generate scripts on their own.

Reviewed-by: Jiuyang Liu <liu@jiuyang.me>
Co-authored-by: sinofp <sinofp@tuta.io>
 [deprecation clean up] remove trait firrtl.util.BackendCompilationUtilities (#2423) 2021-11-30T03:16:02+00:00 Jiuyang Liu 2021-11-30T03:16:02+00:00 a4d13a5024f7488e1d2b9fdd27d3917157a67268 Co-authored-by: Jack Koenig <koenig@sifive.com> 
Co-authored-by: Jack Koenig <koenig@sifive.com>
 fix tests that depend on Driver (#2429) 2021-11-23T18:56:03+00:00 Jiuyang Liu 2021-11-23T18:56:03+00:00 16714d6abeab5140e97d8370e8b901b4eb816fde Co-authored-by: sinofp <sinofp@tuta.io> 
Co-authored-by: sinofp <sinofp@tuta.io>
 BlackBoxSourceHelper: ensure trailing newline in .f file (#2405) 2021-11-04T16:39:08+00:00 Kevin Laeufer 2021-11-04T16:39:08+00:00 7ef3e1ba9d1a748bd39f8d4f279e8d4e34bb4cc7 






TopWiring: filter out unnamed declarations when building source lists (#2376)
2021-09-29T23:58:10+00:00

David Biancolin

2021-09-29T23:58:10+00:00

519e8c8dea592d2faf949a1a1aa49ea303bd1c72

* Demonstrate a couple failing cases

* Have TopWiring ignore unnamed declarations as potential sources




* Demonstrate a couple failing cases

* Have TopWiring ignore unnamed declarations as potential sources






Remove BlackBoxSourceHelper from ReplaceMemTransform (#2355)
2021-09-11T07:29:10+00:00

Jack Koenig

2021-09-11T07:29:10+00:00

beb5bc9850fd69adff36f38fb00a1f68bb1918fe

BlackBoxSourceHelper should only run late in compilation to allow
transforms to tweak its behavior (eg. changing BlackBoxTargetDirAnno).




BlackBoxSourceHelper should only run late in compilation to allow
transforms to tweak its behavior (eg. changing BlackBoxTargetDirAnno).






Make MustDeduplicateAnnotation deletable (#2215)
2021-05-04T20:18:51+00:00

Jack Koenig

2021-05-04T20:18:51+00:00

6db311b39b2330637e5bf47f308e68292eca1381












Fix RemoveAccesses, delete CSESubAccesses (#2157)
2021-03-29T17:21:26+00:00

Jack Koenig

2021-03-29T17:21:26+00:00

a41af6f0a34f9e13866002f19040a40ef55ee9e5

CSESubAccesses was intended to be a simple workaround for a quadratic
performance bug in RemoveAccesses but ended up having tricky corner
cases and was hard to get right. The solution to the RemoveAccesses
bug--quadratic expansion of dynamic indexes of vecs of aggreate
type--turned out to be quite simple and makes CSESubAccesses much less
useful and not worth fixing.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>




CSESubAccesses was intended to be a simple workaround for a quadratic
performance bug in RemoveAccesses but ended up having tricky corner
cases and was hard to get right. The solution to the RemoveAccesses
bug--quadratic expansion of dynamic indexes of vecs of aggreate
type--turned out to be quite simple and makes CSESubAccesses much less
useful and not worth fixing.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>