From 12dd8df3756d58af2f4d1f54eefd90f1ce1e0dbe Mon Sep 17 00:00:00 2001 From: Damien George Date: Sat, 7 May 2016 21:18:17 +0100 Subject: py/objstr: Binary type of str/bytes for buffer protocol is 'B'. The type is an unsigned 8-bit value, since bytes objects are exactly that. And it's also sensible for unicode strings to return unsigned values when accessed in a byte-wise manner (CPython does not allow this). --- py/objstr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'py') diff --git a/py/objstr.c b/py/objstr.c index d0d090b99..3d3845f4a 100644 --- a/py/objstr.c +++ b/py/objstr.c @@ -1806,7 +1806,7 @@ mp_int_t mp_obj_str_get_buffer(mp_obj_t self_in, mp_buffer_info_t *bufinfo, mp_u GET_STR_DATA_LEN(self_in, str_data, str_len); bufinfo->buf = (void*)str_data; bufinfo->len = str_len; - bufinfo->typecode = 'b'; + bufinfo->typecode = 'B'; // bytes should be unsigned, so should unicode byte-access return 0; } else { // can't write to a string -- cgit v1.2.3