From 7e078b070b3acf6c0b24d66a150b09a7df57b09d Mon Sep 17 00:00:00 2001 From: Emilio Jesus Gallego Arias Date: Tue, 11 Feb 2020 11:33:55 +0100 Subject: [misc] Better preserve backtraces in several modules Re-raising inside exception handlers must be done with care in order to preserve backtraces; even if newer OCaml versions do a better job in automatically spilling `%reraise` in places that matter, there is no guarantee for that to happen. I've done a best-effort pass of places that were re-raising incorrectly, hopefully I got the logic right. There is the special case of `Nametab.error_global_not_found` which is raised many times in response to a `Not_found` error; IMHO this error should be converted to something more specific, however the scope of that change would be huge as to do easily... --- dev/ci/user-overlays/11566-ejgallego-exninfo+coercion.sh | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 dev/ci/user-overlays/11566-ejgallego-exninfo+coercion.sh (limited to 'dev') diff --git a/dev/ci/user-overlays/11566-ejgallego-exninfo+coercion.sh b/dev/ci/user-overlays/11566-ejgallego-exninfo+coercion.sh new file mode 100644 index 0000000000..05192facbe --- /dev/null +++ b/dev/ci/user-overlays/11566-ejgallego-exninfo+coercion.sh @@ -0,0 +1,6 @@ +if [ "$CI_PULL_REQUEST" = "11566" ] || [ "$CI_BRANCH" = "exninfo+coercion" ]; then + + mtac2_CI_REF=exninfo+coercion + mtac2_CI_GITURL=https://github.com/ejgallego/Mtac2 + +fi -- cgit v1.2.3