From d4def32456c0fadb7fc9814af7e7b2b21a37f0a6 Mon Sep 17 00:00:00 2001
From: Gaëtan Gilbert
Date: Fri, 9 Mar 2018 13:59:17 +0100
Subject: pre-commit: verify user overlay extensions (must be .sh).

This has come up a couple times.
---
 dev/tools/check-overlays.sh | 11 +++++++++++
 dev/tools/pre-commit        |  2 ++
 2 files changed, 13 insertions(+)
 create mode 100755 dev/tools/check-overlays.sh

(limited to 'dev')

diff --git a/dev/tools/check-overlays.sh b/dev/tools/check-overlays.sh
new file mode 100755
index 0000000000..f7e05b51cd
--- /dev/null
+++ b/dev/tools/check-overlays.sh
@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+
+for f in dev/ci/user-overlays/*
+do
+    if ! ([[ $f = dev/ci/user-overlays/README.md ]] || [[ $f == *.sh ]])
+    then
+        >&2 echo "Bad overlay '$f'."
+        >&2 echo "User overlays need to have extension .sh to be picked up!"
+        exit 1
+    fi
+done
diff --git a/dev/tools/pre-commit b/dev/tools/pre-commit
index c9cdee84ab..a514b8866a 100755
--- a/dev/tools/pre-commit
+++ b/dev/tools/pre-commit
@@ -5,6 +5,8 @@
 
 set -e
 
+dev/tools/check-overlays.sh
+
 if ! git diff --cached --name-only -z | xargs -0 dev/tools/check-eof-newline.sh ||
         ! git diff-index --check --cached HEAD >/dev/null 2>&1 ;
 then
-- 
cgit v1.2.3


From aa1565a20f6c42ba28a9346ee25404d893946c5d Mon Sep 17 00:00:00 2001
From: Gaëtan Gilbert
Date: Fri, 9 Mar 2018 14:05:36 +0100
Subject: Linter: verify overlay extensions.

---
 dev/lint-repository.sh | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'dev')

diff --git a/dev/lint-repository.sh b/dev/lint-repository.sh
index ee9c8777a3..cd09b6d305 100755
--- a/dev/lint-repository.sh
+++ b/dev/lint-repository.sh
@@ -31,4 +31,6 @@ fi
 find . "(" -path ./.git -prune ")" -o -type f -print0 |
     xargs -0 dev/tools/check-eof-newline.sh || CODE=1
 
+dev/tools/check-overlays.sh || CODE=1
+
 exit $CODE
-- 
cgit v1.2.3