From 876f767ef55585e4ed186db3f1d8589cbd4605c1 Mon Sep 17 00:00:00 2001 From: Gaƫtan Gilbert Date: Tue, 9 Jul 2019 12:52:09 +0200 Subject: merge-pr.sh: filter reviews to remove the PR author This removes spurious Ack-by lines --- dev/tools/merge-pr.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'dev/tools') diff --git a/dev/tools/merge-pr.sh b/dev/tools/merge-pr.sh index 425f21de70..c0a3eeb11c 100755 --- a/dev/tools/merge-pr.sh +++ b/dev/tools/merge-pr.sh @@ -209,7 +209,8 @@ has_state() { [ "$(jq -rc 'map(select(.user.login == "'"$1"'") | .state) | any(. == "'"$2"'")' <<< "$reviews")" = true ] } -for reviewer in $(jq -rc 'map(.user.login) | unique | join(" ")' <<< "$reviews" ); do +author=$(echo "$PRDATA" | jq -rc '.user.login') +for reviewer in $(jq -rc 'map(.user.login | select(. != "'"$author"'")) | unique | join(" ")' <<< "$reviews" ); do if has_state "$reviewer" APPROVED; then msg=$(printf '%s\n' "$msg" | git interpret-trailers --trailer Reviewed-by="$reviewer") elif has_state "$reviewer" COMMENTED; then -- cgit v1.2.3