From 37070565e8b7bead15f5abda2c409f1ad2348fa1 Mon Sep 17 00:00:00 2001 From: Théo Zimmermann Date: Fri, 31 Jan 2020 23:14:49 +0100 Subject: Clarify expectations for overlays in contributing guide and CI doc. Contributors are *not* required to prepare all the patches by themselves. They can request help from project authors, who should be ready to take part in this. Also, finish replacing "development" by the more appropriate word "project". --- dev/ci/README-developers.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'dev/ci/README-developers.md') diff --git a/dev/ci/README-developers.md b/dev/ci/README-developers.md index 9ed7180807..dba3d38c6c 100644 --- a/dev/ci/README-developers.md +++ b/dev/ci/README-developers.md @@ -43,9 +43,10 @@ See also [`test-suite/README.md`](../../test-suite/README.md) for information ab ### Breaking changes When your PR breaks an external project we test in our CI, you must -prepare a patch (or ask someone to prepare a patch) to fix the -project. There is experimental support for an improved workflow, see -[the next section](#experimental-automatic-overlay-creation-and-building), below +prepare a patch (or ask someone —possibly the project author— to +prepare a patch) to fix the project. There is experimental support for +an improved workflow, see [the next +section](#experimental-automatic-overlay-creation-and-building), below are the steps to manually prepare a patch: 1. Fork the external project, create a new branch, push a commit adapting -- cgit v1.2.3 From 565645526215065fa3dbc5eee3100da158f463d1 Mon Sep 17 00:00:00 2001 From: Théo Zimmermann Date: Sat, 1 Feb 2020 09:59:34 +0100 Subject: No spaces with em-dashes. Co-Authored-By: Jason Gross --- dev/ci/README-developers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'dev/ci/README-developers.md') diff --git a/dev/ci/README-developers.md b/dev/ci/README-developers.md index dba3d38c6c..6a740b9033 100644 --- a/dev/ci/README-developers.md +++ b/dev/ci/README-developers.md @@ -43,7 +43,7 @@ See also [`test-suite/README.md`](../../test-suite/README.md) for information ab ### Breaking changes When your PR breaks an external project we test in our CI, you must -prepare a patch (or ask someone —possibly the project author— to +prepare a patch (or ask someone—possibly the project author—to prepare a patch) to fix the project. There is experimental support for an improved workflow, see [the next section](#experimental-automatic-overlay-creation-and-building), below -- cgit v1.2.3