From edf85b925939cb13ca82a10873ced589164391da Mon Sep 17 00:00:00 2001
From: Pierre Letouzey
Date: Sat, 3 Jan 2015 18:50:53 +0100
Subject: Declarations.mli refactoring: module_type_body = module_body

 After this commit, module_type_body is a particular case of module_type.
 For a [module_type_body], the implementation field [mod_expr] is
 supposed to be always [Abstract]. This is verified by coqchk, even
 if this isn't so crucial, since [mod_expr] is never read in the case
 of a module type.

 Concretely, this amounts to the following rewrite on field names
 for module_type_body:
  - typ_expr --> mod_type
  - typ_expr_alg --> mod_type_alg
  - typ_* --> mod_*
 and adding two new fields to mtb:
  - mod_expr (always containing Abstract)
  - mod_retroknowledge (always containing [])

 This refactoring should be completely transparent for the user.

 Pros: code sharing, for instance subst_modtype = subst_module.
 Cons: a runtime invariant (mod_expr = Abstract) which isn't
 enforced by typing. I tried a polymorphic typing of mod_expr,
 to share field names while not having mtb = mb, but the OCaml
 typechecker isn't clever enough with polymorphic mutual fixpoints,
 and reject code sharing (e.g. between subst_modtype and subst_module).
 In the future (with ocaml>=4), some GADT could maybe help here,
 but for now the current solution seems good enough.
---
 checker/declarations.ml | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

(limited to 'checker/declarations.ml')

diff --git a/checker/declarations.ml b/checker/declarations.ml
index d38df793f6..c6709a7852 100644
--- a/checker/declarations.ml
+++ b/checker/declarations.ml
@@ -591,23 +591,17 @@ let rec subst_expr sub = function
   | MEwith (me,wd)-> MEwith (subst_expr sub me, subst_with_body sub wd)
 
 let rec subst_expression sub me =
-  functor_map (subst_modtype sub) (subst_expr sub) me
+  functor_map (subst_module sub) (subst_expr sub) me
 
 and subst_signature sub sign =
-  functor_map (subst_modtype sub) (subst_structure sub) sign
-
-and subst_modtype sub mtb=
-  { mtb with
-    typ_mp = subst_mp sub mtb.typ_mp;
-    typ_expr = subst_signature sub mtb.typ_expr;
-    typ_expr_alg = Option.smartmap (subst_expression sub) mtb.typ_expr_alg }
+  functor_map (subst_module sub) (subst_structure sub) sign
 
 and subst_structure sub struc =
   let subst_body = function
     | SFBconst cb -> SFBconst (subst_const_body sub cb)
     | SFBmind mib -> SFBmind (subst_mind sub mib)
-    | SFBmodule mb -> SFBmodule (subst_module sub  mb)
-    | SFBmodtype mtb -> SFBmodtype (subst_modtype sub mtb)
+    | SFBmodule mb -> SFBmodule (subst_module sub mb)
+    | SFBmodtype mtb -> SFBmodtype (subst_module sub mtb)
   in
   List.map (fun (l,b) -> (l,subst_body b)) struc
 
@@ -617,5 +611,4 @@ and subst_module sub mb =
     mod_expr =
       implem_map (subst_signature sub) (subst_expression sub) mb.mod_expr;
     mod_type = subst_signature sub mb.mod_type;
-    mod_type_alg = Option.map (subst_expression sub) mb.mod_type_alg }
-
+    mod_type_alg = Option.smartmap (subst_expression sub) mb.mod_type_alg }
-- 
cgit v1.2.3