From ee2c5352d95adee5a31689c79785547c0dbaa749 Mon Sep 17 00:00:00 2001
From: Hugo Herbelin
Date: Mon, 2 Mar 2020 12:00:41 +0100
Subject: Deprecation of catchable_exception, to be replaced by noncritical in
 try-with.

---
 dev/doc/changes.md        | 7 +++++++
 proofs/logic.mli          | 1 +
 tactics/class_tactics.mli | 1 +
 3 files changed, 9 insertions(+)

diff --git a/dev/doc/changes.md b/dev/doc/changes.md
index d5938713d6..9088df6856 100644
--- a/dev/doc/changes.md
+++ b/dev/doc/changes.md
@@ -2,6 +2,13 @@
 
 ### ML API
 
+Refiner.catchable_exception is deprecated, use instead
+CErrors.noncritical in try-with block. Note that nothing is needed in
+tclORELSE block since the exceptions there are supposed to be
+non-critical by construction.
+
+### ML API
+
 Types `precedence`, `parenRelation`, `tolerability` in
 `notgram_ops.ml` have been reworked. See `entry_level` and
 `entry_relative_level` in `constrexpr.ml`.
diff --git a/proofs/logic.mli b/proofs/logic.mli
index 1046fd8b29..525c303d5b 100644
--- a/proofs/logic.mli
+++ b/proofs/logic.mli
@@ -50,6 +50,7 @@ exception RefinerError of Environ.env * evar_map * refiner_error
 val error_no_such_hypothesis : Environ.env -> evar_map -> Id.t -> 'a
 
 val catchable_exception : exn -> bool
+[@@ocaml.deprecated "This function does not scale in the presence of dynamically added exceptions. Use instead CErrors.noncritical, or the exact name of the exception that matters in the corresponding case."]
 
 (** Move destination for hypothesis *)
 
diff --git a/tactics/class_tactics.mli b/tactics/class_tactics.mli
index dc94e6a6fb..394ef9a6b5 100644
--- a/tactics/class_tactics.mli
+++ b/tactics/class_tactics.mli
@@ -16,6 +16,7 @@ open EConstr
 val typeclasses_db : string
 
 val catchable : exn -> bool
+[@@ocaml.deprecated "Use instead CErrors.noncritical, or the exact name of the exception that matters in the corresponding case."]
 
 val set_typeclasses_debug : bool -> unit
 val get_typeclasses_debug : unit -> bool
-- 
cgit v1.2.3