| Age | Commit message (Collapse) | Author |
|
became mandatory.
|
|
with user-level notations by inserting spaces.
|
|
|
|
|
|
We defactorize the in_clause grammar entry to allow parsing of the "symmetry"
tactic when it has no arguments. Beforehand, the clause_dft_concl entry
accepted the empty stream, preventing the definition of symmetry as a mere
identifier.
|
|
One of them revealed a true bug.
|
|
|
|
module)
For the moment, there is an Error module in compilers-lib/ocamlbytecomp.cm(x)a
|
|
|
|
simplifying and generalizing the grammar entries for injection,
discriminate and simplify_eq.
|
|
In pat%constr, creating new evars is now allowed only if "eintros" is
given, i.e. "intros" checks that no evars are created, and similarly
e.g. for "injection ... as ... pat%constr".
The form "eintros [...]" or "eintros ->" with the case analysis or
rewrite creating evars is now also supported.
This is not a commitment to say that it is good to have an e- modifier
to tactics. It is just to be consistent with the existing convention.
It seems to me that the "no e-" variants are good for beginners. However,
expert might prefer to use the e-variants by default. Opinions from
teachers and users would be useful.
To be possibly done: do that [= ...] work on hypotheses with side
conditions or parameters based on the idea that they apply the full
injection and not only the restriction of it to goals which are
exactly an equality, as it is today.
|
|
|
|
|
|
|
|
|
|
|
|
simpler re-printing of assert.
Also fixing the precedence for printing "by" clause.
|
|
|
|
Tactic Notation "f" constr(x) := apply x. Ltac g x := f x.
Goal False.
g I. (* Was printing Top.Top#<>#1 *)
idtac; f I. (* Was not properly locating error *)
This is a "a minima" fix.
This a different fix than in trunk, so the merge will have to take the
trunk version.
|
|
An Ltac trace printing mechanism was introduced in 8.4 which was
inadvertedly modified by a series of commits such as 8e10368c3,
91f44f1da7a, ...
It was also sometimes buggy, iirc, when entering ML tactics which
themselves were calling ltac code.
It got really bad in 8.5 as in:
Tactic Notation "f" constr(x) := apply x. Ltac g x := f x.
Goal False.
idtac; f I. (* bad location reporting *)
g I. (* was referring to tactic name "Top.Top#<>#1" *)
which this commit fixes.
I don't have a clear idea of what would be the best ltac tracing
mechanism, but to avoid it to be broken without being noticed, I
started to add some tests.
Eventually, it might be worth that an Ltac expert brainstrom on it!
|
|
|
|
|
|
Note that this breaks the compatibility, in a beneficial way I believe. Tactics
defined in strict mode (i.e. through Ltac foo := ...) may not do an introduction
on a local identifier anymore. They must use the "fresh" primitive instead.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This reverts commit bde36d4b00185065628324d8ca71994f84eae244.
|
|
This reverts commit c4ce1baa9f66210ebc1909988b3dd8baa1b8ef27.
|
|
This reverts commit 691dc7d88c6810333eecef7c2f0b8d8617d19ab1.
|
|
This reverts commit 9b1b5de7a70c54ba3d60560d3d097f3eee2ca907.
|
|
This reverts commit 6da8866a4fd79029b22bd1bf7cde6725a9ea259c.
|
|
This reverts commit d408e09e5366899f4313f433cc9507ea92458c49.
|
|
This reverts commit 0d56fda01ecf8b38ef5f9a1fd3552f025972fbcd.
|
|
This reverts commit 8c74d3e5578caeb5c62ba462528d9972c1de17f1.
|
|
This reverts commit 90252e973f5bcafc5f3b0b18564612d7fb4503a8.
|
|
This reverts commit 043d6a5c113a11fe9955cbe71b8f4bcd08af9a90.
|
|
EXTEND and""
This reverts commit eb9216e544cb5fce4347052f42e9452a822c2f64.
|
|
This reverts commit fb1b7b084bcbbbc176040fcadeac00aee6b1e462.
|
|
arguments of vernac extensions, so that in list with a separator, the
separator is printed.
|
|
side of Ltac's "let ... in ..." or "match ... with ... => ... end".
Example:
Ltac f x := let x := 0 in constr:(S x).
Print Ltac f.
has a missing "constr:".
Note: for generic arguments: "ltac:" is always used, even if a constr, etc.
|
|
the remaining issue with the fix to #3709.
However, this does not solve the problem in mind which is that
"intuition idtac; idtac" is printed with extra parentheses into
"intuition (idtac; idtac)".
If one change the level of printing of TacArg of Tacexp from latom to
inherited, this breaks elsewhere, with "let x := (simpl) in idtac"
printed "let x := simpl in idtac".
|
|
with user-level notations by inserting spaces.
|
|
|
|
|
|
|