From a7f4eb76935157112aa844b6c5ac29a36898235f Mon Sep 17 00:00:00 2001 From: Erik Martin-Dorel Date: Fri, 17 Jan 2020 16:14:38 +0100 Subject: Revert "Don't run "opam clean -c" to workaround ocaml/opam#3828" This reverts commit a03e0cb0ff40afabcaccba7f764076355ca82962. --- Dockerfile.make | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Dockerfile.make') diff --git a/Dockerfile.make b/Dockerfile.make index 1a1dfc2..bb8b653 100644 --- a/Dockerfile.make +++ b/Dockerfile.make @@ -21,7 +21,7 @@ RUN ["/bin/bash", "--login", "-c", "set -x \ && opam repository add --all-switches --set-default coq-core-dev https://coq.inria.fr/opam/core-dev \ && opam update -y \ && opam config list && opam repo list && opam list && coqc --version \ - && opam clean -a -s --logs \ + && opam clean -a -c -s --logs \ && sudo chown -R coq:coq /home/coq/mathcomp \ && cd mathcomp \ && make Makefile.coq \ -- cgit v1.2.3 From 563f395e1a41caf4978fe9881250ec68796e36a0 Mon Sep 17 00:00:00 2001 From: Erik Martin-Dorel Date: Sun, 8 Mar 2020 15:22:33 +0100 Subject: refactor: Simplify the Dockerfiles * the CLI option --build-arg=compiler="${OPAM_SWITCH}" is now useless (it had been introduced to be able to compile Coq versions < 8.7, while mathcomp-dev now requires Coq 8.7+) * the "coqorg/base:bare" image now contains the two environment vars COMPILER and COMPILER_EDGE => clear COMPILER="" in mathcomp-dev's Dockerfile multi-stage build. --- Dockerfile.make | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) (limited to 'Dockerfile.make') diff --git a/Dockerfile.make b/Dockerfile.make index bb8b653..8f305ae 100644 --- a/Dockerfile.make +++ b/Dockerfile.make @@ -5,18 +5,12 @@ WORKDIR /home/coq/mathcomp COPY . . -ARG compiler="base" -# other possible value: "edge" - RUN ["/bin/bash", "--login", "-c", "set -x \ - && declare -A switch_table \ - && switch_table=( [\"base\"]=\"${COMPILER}\" [\"edge\"]=\"${COMPILER_EDGE}\" ) \ - && opam_switch=\"${switch_table[${compiler}]}\" \ - && [ -n \"opam_switch\" ] \ - && opam switch set ${opam_switch} \ + && [ -n \"${COMPILER_EDGE}\" ] \ + && opam switch set \"${COMPILER_EDGE}\" \ && eval $(opam env) \ - && unset \"switch_table[${compiler}]\" \ - && for sw in \"${switch_table[@]}\"; do [ -n \"$sw\" ] && opam switch remove -y \"${sw}\"; done \ + && [ -n \"${COMPILER}\" ] \ + && opam switch remove -y \"${COMPILER}\" \ && opam repository add --all-switches --set-default coq-extra-dev https://coq.inria.fr/opam/extra-dev \ && opam repository add --all-switches --set-default coq-core-dev https://coq.inria.fr/opam/core-dev \ && opam update -y \ -- cgit v1.2.3