From c907eabfb65cd6442e35588b095ca031e2bdad7a Mon Sep 17 00:00:00 2001 From: Andrew Waterman Date: Sun, 7 Aug 2016 17:09:42 -0700 Subject: Legalize identifier names before printing It's not entirely clear what the FIRRTL implementation supports, so I'm using the ANSI C requirements for the time being. --- .../src/main/scala/chisel3/internal/Builder.scala | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/chiselFrontend/src/main/scala/chisel3/internal/Builder.scala b/chiselFrontend/src/main/scala/chisel3/internal/Builder.scala index 0e0a88cc..cecbd91e 100644 --- a/chiselFrontend/src/main/scala/chisel3/internal/Builder.scala +++ b/chiselFrontend/src/main/scala/chisel3/internal/Builder.scala @@ -21,16 +21,25 @@ private[chisel3] class Namespace(parent: Option[Namespace], keywords: Set[String if (this contains tryName) rename(n) else tryName } + private def sanitize(s: String): String = { + // TODO what character set does FIRRTL truly support? using ANSI C for now + def legalStart(c: Char) = (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z') || c == '_' + def legal(c: Char) = legalStart(c) || (c >= '0' && c <= '9') + val res = s filter legal + if (res.isEmpty || !legalStart(res.head)) s"_$res" else res + } + def contains(elem: String): Boolean = { names.contains(elem) || parent.map(_ contains elem).getOrElse(false) } def name(elem: String): String = { - if (this contains elem) { - name(rename(elem)) + val sanitized = sanitize(elem) + if (this contains sanitized) { + name(rename(sanitized)) } else { - names(elem) = 1 - elem + names(sanitized) = 1 + sanitized } } -- cgit v1.2.3