From 42c883b478995ff5d8dfc7dcaaf1424d7a7659d1 Mon Sep 17 00:00:00 2001 From: Adam Izraelevitz Date: Fri, 21 Aug 2020 15:39:23 -0700 Subject: Updated PR template to include checklist and documentation updates (#1562) * Updated PR template to include checklist and documentation updates * Change milestones to 3.x.x * updated milestones--- .github/PULL_REQUEST_TEMPLATE.md | 54 ++++++++++++++++++++++++++++++++-------- 1 file changed, 43 insertions(+), 11 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index cdb2e3df..1a661ea8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,18 +1,50 @@ - -**Related issue**: +### Contributor Checklist + +- [ ] Did you add Scaladoc to every public function/method? +- [ ] Did you add at least one test demonstrating the PR? +- [ ] Did you delete any extraneous printlns/debugging code? +- [ ] Did you specify the type of improvement? +- [ ] Did you add appropriate documentation in `docs/src`? +- [ ] Did you state the API impact? +- [ ] Did you specify the code generation impact? +- [ ] Did you request a desired merge strategy? +- [ ] Did you add text to be included in the Release Notes for this change? + +#### Type of Improvement + + + + + + + + + - -**Type of change**: bug report | feature request | documentation | other enhancement +#### API Impact - -**Impact**: no functional change | API addition (no impact on existing code) | API modification + - -**Development Phase**: proposal | implementation +#### Backend Code Generation Impact -**Release Notes** + + + +#### Desired Merge Strategy + + + + + + +#### Release Notes + +### Reviewer Checklist (only modified by reviewer) +- [ ] Did you add the appropriate labels? +- [ ] Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ? +- [ ] Did you review? +- [ ] Did you check whether all relevant Contributor checkboxes have been checked? +- [ ] Did you mark as `Please Merge`? -- cgit v1.2.3