chiselX/src/test/scala/chiselTests/aop, branch scala3-main-test Chisel with SFC compatibility Don't invalidate ExtModule ports in an explicitInvalidate = true context (backport #2795) (#2799) 2022-10-23T19:01:43+00:00 mergify[bot] 2022-10-23T19:01:43+00:00 d997acb05e5a307afb7c9ad4c136b9b4e1506efc * Don't invalidate ExtModule ports in an explicitInvalidate = true context (#2795) * Don't invalidate ExtModule ports in an explicitInvalidate = true context ExtModule ports were previously invalidated in the emitted FIRRTL, which is correct in a NonStrict / `Chisel._` compatibility context but not in newer chisel3 code where `explicitInvalidate = true`. (cherry picked from commit 8e24a281545d25f6501dcc872eabdfb30bacd69d) # Conflicts: # core/src/main/scala/chisel3/BlackBox.scala * Resolve backport conflicts Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com> Co-authored-by: Jack Koenig <koenig@sifive.com> 
* Don't invalidate ExtModule ports in an explicitInvalidate = true context (#2795)

* Don't invalidate ExtModule ports in an explicitInvalidate = true context

ExtModule ports were previously invalidated in the emitted FIRRTL, which is correct in a NonStrict / `Chisel._` compatibility context but not in newer chisel3 code where `explicitInvalidate = true`.

(cherry picked from commit 8e24a281545d25f6501dcc872eabdfb30bacd69d)

# Conflicts:
#	core/src/main/scala/chisel3/BlackBox.scala

* Resolve backport conflicts

Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
 Apply scalafmt 2022-01-10T23:53:55+00:00 Jack Koenig 2022-01-10T18:39:52+00:00 3131c0daad41dea78bede4517669e376c41a325a Command: sbt scalafmtAll 
Command:
sbt scalafmtAll
make all verification statements publically available (#2089) 2021-09-23T18:12:26+00:00 Kevin Laeufer 2021-09-23T18:12:26+00:00 d1d38bd096fce8b92468720fbedc835ecda40e6b 






Add Definition and Instance API (#2045)
2021-09-05T19:11:32+00:00

Adam Izraelevitz

2021-09-05T19:11:32+00:00

9fa8da227569455a77596355aeb114f9c164510a

This introduces a new experimental API for module instantiation that disentagles
elaborating the definition (or implementation) from instantiation of
a given module. This solves Chisel's longstanding reliance on
"Deduplication" for generating Verilog with multiple instances of the
same module.

The new API resides in package chisel3.experimental.hierarchy. Please
see the hierarchy ScalaDoc, documentation, and tests for examples of
use.

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>




This introduces a new experimental API for module instantiation that disentagles
elaborating the definition (or implementation) from instantiation of
a given module. This solves Chisel's longstanding reliance on
"Deduplication" for generating Verilog with multiple instances of the
same module.

The new API resides in package chisel3.experimental.hierarchy. Please
see the hierarchy ScalaDoc, documentation, and tests for examples of
use.

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>






Make printf return BaseSim subclass so it can be named/annotated (#1992)
2021-07-06T21:40:59+00:00

Deborah Soung

2021-07-06T21:40:59+00:00

503ae520e7f997bcbc639b79869c9a4214d402ed












Change behavior of aop.Select to not include CloneModuleAsRecord
2021-06-29T23:55:15+00:00

Jack Koenig

2021-06-29T23:39:45+00:00

25a84b5667614ea3f437b656f1939caba57e6f66

Previously, CloneModuleAsRecord clones would result in the same
BaseModule object coming up multiple times when using APIs like
.instances, .collectDeep, and .getDeep. This was not the intended
behavior and can lead to very subtle bugs.





Previously, CloneModuleAsRecord clones would result in the same
BaseModule object coming up multiple times when using APIs like
.instances, .collectDeep, and .getDeep. This was not the intended
behavior and can lead to very subtle bugs.







Restore aop.Select behavior for CloneModuleAsRecord
2021-06-29T22:34:18+00:00

Jack Koenig

2021-06-29T22:34:18+00:00

0531cb53d3cedaff33c2a280e34418f6af5bc6a1












fixing context bug (#1874)
2021-04-21T21:47:03+00:00

Deborah Soung

2021-04-21T21:47:03+00:00

2c7264a6d923e2d1dc645c8b7dec2add7fb6cfbc












Bugfix - adding external modules was broken (#1649)
2020-11-02T20:18:46+00:00

Adam Izraelevitz

2020-11-02T20:18:46+00:00

d21fe713aa79b660db3350addd274507dd2edfd4












Bugfix - module name collision for injecting aspect (#1635)
2020-10-26T21:59:17+00:00

Adam Izraelevitz

2020-10-26T21:59:17+00:00

1b6bd89dfafc774af1c926a982418294091f6346

* Bugfix - module name collision for injecting aspect

* Fixed mechanism to avoid module name collisions

* Added comments for reviewer feedback

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>




* Bugfix - module name collision for injecting aspect

* Fixed mechanism to avoid module name collisions

* Added comments for reviewer feedback

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>